Django

Code

Ticket #6935 (closed: fixed)

Opened 8 months ago

Last modified 4 months ago

inspectdb should handle table names with spaces.

Reported by: adamv Assigned to: jdunck
Milestone: 1.0 Component: django-admin.py inspectdb
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Some databases allow tables with spaces in the name, assuming that these table names are properly quoted in queries. (MS Sql Server, for example.)

The table-name-to-python-class-name lambda in inspectdb isn't handling spaces, which is generating invalid python class names.

This patch address that issue.

Attachments

handle-table-name-spaces.diff (0.6 kB) - added by adamv on 04/01/08 11:04:36.

Change History

04/01/08 11:04:36 changed by adamv

  • attachment handle-table-name-spaces.diff added.

06/14/08 10:30:23 changed by telenieko

  • needs_better_patch changed.
  • has_patch set to 1.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • needs_docs changed.

06/15/08 06:30:58 changed by anonymous

#7285 is the same problem with field names and dashes.

08/15/08 19:23:07 changed by jdunck

  • milestone set to 1.0.

08/15/08 19:31:14 changed by jdunck

  • owner changed from nobody to jdunck.

08/15/08 23:53:32 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [8403]) Fixed #6935: Modified inspectdb to provide better handling for table names with spaces. Thanks to adamv for the report and patch.

Add/Change #6935 (inspectdb should handle table names with spaces.)




Change Properties
Action