Django

Code

Ticket #6750 (new)

Opened 6 months ago

Last modified 1 month ago

Invalid xhtml in AdminFileWidget (target="_blank")

Reported by: garcia_marc Assigned to: garcia_marc
Milestone: Component: Admin interface
Version: newforms-admin Keywords: admin invalid xhtml AdminFileWidget nfa-someday
Cc: Triage Stage: Design decision needed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

As requested in #5695, here is the fix for the invalid xhtml in the AdminFileWidget?. It's just a target="_blank" replaced by the javascript open.window().

May be I could develop another patch changing string variables by a dictionay to make the code clearer.

Attachments

6750.diff (0.8 kB) - added by garcia_marc on 03/10/08 15:13:14.
Patch for the ticket (without a dictionary as string variables)

Change History

03/10/08 15:13:14 changed by garcia_marc

  • attachment 6750.diff added.

Patch for the ticket (without a dictionary as string variables)

03/11/08 15:16:40 changed by jacob

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

Hm. I'm not sure I like doing this all that much -- embedding Javascript in HTML in Python feels super yucky. Personally, I'm OK with the invalid XHTML as long at it works.

05/16/08 12:11:23 changed by garcia_marc

  • keywords changed from admin invalid xhtml AdminFileWidget to admin invalid xhtml AdminFileWidget fs-rf.

What about simply removing the target="_blank", or moving the javascript to a .js file?

It's supposed to be a framework for perfectionists, we shouldn't leave the invalid code in there... ;)

06/09/08 16:55:32 changed by Karen Tracey <kmtracey@gmail.com>

  • keywords changed from admin invalid xhtml AdminFileWidget fs-rf to admin invalid xhtml AdminFileWidget fs-rf nfa-someday.

Jacob's comment makes me think this is not critical to be addressed before nfa merge?

06/16/08 12:27:57 changed by Gulopine

  • keywords changed from admin invalid xhtml AdminFileWidget fs-rf nfa-someday to admin invalid xhtml AdminFileWidget nfa-someday.

The filestorage refactor has nothing to do with widgets, much less anything admin-specific, so I'm removing the fs-rf keyword.

07/22/08 15:43:57 changed by garcia_marc

  • owner changed from nobody to garcia_marc.

Add/Change #6750 (Invalid xhtml in AdminFileWidget (target="_blank"))




Change Properties
Action