Django

Code

Ticket #5695 (closed: fixed)

Opened 9 months ago

Last modified 4 months ago

[newform-admin] - i18n and xhtml problem in AdminFileWidget

Reported by: Petr Marhoun <petr.marhoun@gmail.com> Assigned to: nobody
Milestone: Component: Admin interface
Version: newforms-admin Keywords: nfa-blocker AdminFileWidget i18n invalid html
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Improvements introduced in [6457] are not internationalized and are not xhtml compatible.

Attachments

admin-file-widget.diff (0.7 kB) - added by Petr Marhoun <petr.marhoun@gmail.com> on 10/06/07 19:47:59.
5695.diff (1.4 kB) - added by garcia_marc on 12/08/07 09:54:31.
Improved patch

Change History

10/06/07 19:47:59 changed by Petr Marhoun <petr.marhoun@gmail.com>

  • attachment admin-file-widget.diff added.

10/15/07 10:32:06 changed by brosner

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • needs_tests changed.
  • needs_docs changed.

Looks good to me. Marking as Ready for checkin.

12/08/07 09:26:00 changed by garcia_marc

  • cc set to marc.garcia@accopensys.com.
  • keywords set to AdminFileWidget i18n invalid html.
  • component changed from Internationalization to Admin interface.

Previous patch improved:

* target="_blank" isn't valid in xhtml strict, changed to javascript * Translatable labels not including colon * Tests added

12/08/07 09:54:31 changed by garcia_marc

  • attachment 5695.diff added.

Improved patch

12/10/07 10:48:55 changed by brosner

  • keywords changed from AdminFileWidget i18n invalid html to nfa-blocker AdminFileWidget i18n invalid html.

This is pretty trivial and does need to be fixed before a merge to trunk. Tagging nfa-blocker.

03/10/08 13:06:29 changed by brosner

I am going to fix this, but can the target="_blank" stuff be opened in a new ticket. I would rather deal with that separately.

03/10/08 13:08:30 changed by brosner

  • status changed from new to closed.
  • resolution set to fixed.

(In [7212]) newforms-admin: Fixed #5695. AdminFileWidget? now properly marks strings for translation and a minor XHTML fix.

03/10/08 15:14:48 changed by garcia_marc

  • cc deleted.

Thanks for commiting.

Your ticket for target="_blank" is #6750

Add/Change #5695 ([newform-admin] - i18n and xhtml problem in AdminFileWidget)




Change Properties
Action