Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#5888 closed (fixed)

Add head, options, put, delete to test Client

Reported by: Scott Barr <scott@…> Owned by: Leah Culver
Component: Testing framework Version: dev
Severity: Keywords: Client
Cc: Gabriel, David Larlet, Jeff Balogh Triage Stage: Accepted
Has patch: yes Needs documentation: yes
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

To aid in unit testing RESTful interfaces I've added methods to the HTTP Client to support HEAD, OPTIONS, PUT and DELETE.

No tests.

Change History (17)

by Scott Barr <scott@…>, 17 years ago

Attachment: test.client.patch​ added

First cut. Addition of head, options, put and delete methods.

by Scott Barr <scott@…>, 17 years ago

Attachment: django.test.client.patch​ added

Changed the patch so that the file path is relative to the django source directory.

by Scott Barr <scott@…>, 17 years ago

Attachment: django.test.client.2.patch​ added

Last "fixed" patch was incorrect.

comment:1 by Russell Keith-Magee, 17 years ago

Needs tests: set

comment:2 by Simon Greenhill <dev@…>, 17 years ago

Triage Stage: Unreviewed → Design decision needed

comment:3 by Gabriel, 17 years ago

Cc: Gabriel added

i'd like to add my support for this. django test client could really use this for RESTful web service design -- an area we should be embracing.

comment:4 by Russell Keith-Magee, 17 years ago

Needs documentation: set
Triage Stage: Design decision needed → Accepted

The idea and implementation is sound; however, this needs tests and documentation before it can go into trunk.

comment:5 by antti@…, 17 years ago

I needed DELETE and PUT too, implemented them before checking here myself, and actually my methods were quite similar.

Besides that, someone ought to get rid of the Content-Type header in GET requests, as GETs really do not have one...

comment:6 by David Larlet, 17 years ago

Cc: David Larlet added
Owner: changed from nobody to David Larlet

I'll try to complete the patch.

comment:7 by Michael Radziej, 17 years ago

milestone: → post-1.0

comment:8 by Leah Culver, 17 years ago

Owner: changed from David Larlet to Leah Culver
Status: new → assigned

by Leah Culver, 17 years ago

Attachment: 5888-r9050.diff​ added

Added tests and docs to previous patch

comment:9 by Jeff Balogh, 17 years ago

Cc: Jeff Balogh added

comment:10 by Malcolm Tredinnick, 17 years ago

Resolution: → fixed
Status: assigned → closed

(In [9186]) Fixed #5888 -- Added methods to the test client to support HEAD, PUT, DELETE
and OPTIONS support. Thanks Scott Barr and Leah Culver.

comment:11 by Malcolm Tredinnick, 17 years ago

(In [9188]) Fixed #5888 -- Added methods to the test client to support HEAD, PUT, DELETE
and OPTIONS support. Thanks Scott Barr and Leah Culver.

comment:12 by Malcolm Tredinnick, 17 years ago

Because I'm a moron, r9186 was committed to the wrong branch, backed out in r9187 and committed to trunk in r9188. Nothing (else) to see here. Move along.

comment:13 by (none), 16 years ago

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top