Django

Code

Ticket #5887 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

consolidate common code in SafeMIMEText and SafeMIMEMultipart

Reported by: Carl Karsten <carl@personnelware.com> Assigned to: nobody
Milestone: Component: django.core.mail
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Browsing the source, noticed the same code in 2 places. moved it into def forbid_multi_line_headers(name, val):

Did not include setitem call - would have been messy, and removed any chance of that function being useful for anything else.

Attachments

mail.diff (1.9 kB) - added by Carl Karsten <carl@personnelware.com> on 11/06/07 22:12:37.
svn diff django/core/mail.py

Change History

11/06/07 22:12:37 changed by Carl Karsten <carl@personnelware.com>

  • attachment mail.diff added.

svn diff django/core/mail.py

12/01/07 20:31:40 changed by Simon G <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Ready for checkin.
  • summary changed from cosolidate common code in SafeMIMEText and SafeMIMEMultipart to consolidate common code in SafeMIMEText and SafeMIMEMultipart.
  • needs_tests changed.
  • needs_docs changed.

01/01/08 23:29:11 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [6987]) Fixed #5887 -- Consolidated some duplicate code in SafeMIMEText and SafeMIMEMultipart. Thanks, Carl Karsten

Add/Change #5887 (consolidate common code in SafeMIMEText and SafeMIMEMultipart)




Change Properties
Action