Django

Code

Ticket #5682 (closed: wontfix)

Opened 1 year ago

Last modified 5 months ago

Support data sent via HTTP PUT in HttpRequest

Reported by: mtredinnick Assigned to: david
Milestone: Component: HTTP handling
Version: SVN Keywords:
Cc: listuser@peternixon.net, stuhlmueller@gmail.com Triage Stage: Accepted
Has patch: 0 Needs documentation: 1
Needs tests: 1 Patch needs improvement: 0

Description

We should add a PUT attribute to the HttpRequest class so that we can use that verb as well (useful for REST scenarios).

Attachments

patch_django_5682_http.diff (2.2 kB) - added by david on 10/06/07 19:22:05.
Patch against django.http.init.py
patch_django_5682_modpython.diff (2.5 kB) - added by listuser@peternixon.net on 10/08/07 06:19:18.
patch_django_5682_wsgi.diff (2.1 kB) - added by david on 10/10/07 09:31:25.
patch_django_5682_client.diff (1.6 kB) - added by david on 10/10/07 10:16:50.
Need documentation on testing.txt
patch_django_5682.diff (9.2 kB) - added by david on 10/23/07 05:38:37.
Patch for http request, wsgi and tests' client, without documentation and tests (modpython patch is missing too)
patch_django_5682.20071203.diff (12.7 kB) - added by david on 12/03/07 16:38:13.
This time with mod_python, still need tests. Review welcome.
patch_django_5682.20080131.diff (12.9 kB) - added by david on 01/31/08 09:39:17.
_get_data was missing for mod_python, now mod_python is tested
patch_django_5682.20080309.diff (15.5 kB) - added by david on 03/09/08 04:53:16.
Patch against r7207, no improvements yet

Change History

10/06/07 11:43:06 changed by david

  • owner changed from nobody to david.
  • needs_better_patch changed.
  • status changed from new to assigned.
  • needs_tests changed.
  • needs_docs changed.

First patch against wsgi, I need to be sure that it's the right way to do before doing the same with modpython (and adding tests?). Discussion on the devel mailing-list: http://groups.google.fr/group/django-developers/browse_thread/thread/a121b2ed850c93ab

It solves the bug if you use django-rest-interface.

10/06/07 19:22:05 changed by david

  • attachment patch_django_5682_http.diff added.

Patch against django.http.init.py

10/07/07 14:49:03 changed by anonymous

  • cc set to listuser@peternixon.net.

10/08/07 06:19:18 changed by listuser@peternixon.net

  • attachment patch_django_5682_modpython.diff added.

10/09/07 17:02:03 changed by anonymous

  • cc changed from listuser@peternixon.net to listuser@peternixon.net, stuhlmueller@gmail.com.

10/10/07 09:31:25 changed by david

  • attachment patch_django_5682_wsgi.diff added.

10/10/07 09:35:11 changed by david

I previously forgot to add PUT informations in request.REQUEST.

Peter, I hadn't modified your patch because you hadn't uploaded your patches against http.parse_file_upload and http.QuerySet? which seemed to be modified too because it returns PUT informations.

I'm working on the client, close to the end.

10/10/07 10:16:50 changed by david

  • attachment patch_django_5682_client.diff added.

Need documentation on testing.txt

10/23/07 05:38:37 changed by david

  • attachment patch_django_5682.diff added.

Patch for http request, wsgi and tests' client, without documentation and tests (modpython patch is missing too)

10/23/07 05:44:43 changed by david

I know that there is still a lack of documentation and tests but you can help me:

  • if you use modpython (Peter)
  • if you want to adapt restapi (Andreas)

I had added request.DATA as discussed on the mailing-list thread.

12/03/07 16:38:13 changed by david

  • attachment patch_django_5682.20071203.diff added.

This time with mod_python, still need tests. Review welcome.

01/31/08 09:39:17 changed by david

  • attachment patch_django_5682.20080131.diff added.

_get_data was missing for mod_python, now mod_python is tested

03/02/08 09:51:07 changed by jacob

  • stage changed from Unreviewed to Accepted.

03/02/08 12:04:17 changed by david

  • needs_docs set to 1.
  • needs_tests set to 1.

Ok, I'll update tests and documentation.

03/09/08 04:53:16 changed by david

  • attachment patch_django_5682.20080309.diff added.

Patch against r7207, no improvements yet

04/09/08 11:09:47 changed by david

  • status changed from assigned to closed.
  • resolution set to wontfix.

Considering the PUT addition, I had discussed with mtredinnick and it appears that it's not useful given the fact you've got request._raw_post_data and nothing states that PUTed data is formencoded (what I hadn't take care before). django-rest-interface project need to be updated to reflect that decision.

A separate bug #5888 had been declared in order to improve the testing client so I close this ticket as wontfix.

Add/Change #5682 (Support data sent via HTTP PUT in HttpRequest)




Change Properties
Action