Django

Code

Ticket #5376 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Add --addrport option to testserver command

Reported by: toddobryan Assigned to: toddobryan
Milestone: Component: django-admin.py
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Because the testserver command takes fixtures as arguments, you can't currently set the IP address or port that it should use when it runs the server.

This ticket adds the option --addrport to testserver and just passes it to the runserver command.

Attachments

testserver-addrport.patch (3.1 kB) - added by toddobryan on 09/11/07 20:27:32.
docs.patch (0.8 kB) - added by toddobryan on 09/16/07 10:28:50.

Change History

09/09/07 21:40:47 changed by toddobryan

  • owner changed from nobody to toddobryan.
  • needs_better_patch changed.
  • status changed from new to assigned.
  • needs_tests changed.
  • needs_docs changed.

09/09/07 22:47:42 changed by adrian

Patch looks good, other than the fact that it should be made relative to your trunk directory -- i.e., the diff shouldn't contain "/home/tobryan1/workspace". Also, could you include a patch to docs/django-admin.txt? Here's all you need to know about documentation changes: http://www.djangoproject.com/documentation/contributing/#documentation-style

09/09/07 22:47:51 changed by adrian

  • stage changed from Unreviewed to Accepted.

09/09/07 22:47:56 changed by adrian

  • needs_docs set to 1.

09/11/07 20:27:32 changed by toddobryan

  • attachment testserver-addrport.patch added.

09/11/07 20:28:28 changed by toddobryan

  • needs_docs deleted.

09/14/07 03:55:17 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Accepted to Ready for checkin.

09/14/07 12:14:45 changed by adrian

I'm working on reviewing this and checking it in.

09/14/07 14:17:15 changed by adrian

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6204]) Fixed #5376 -- Added --addrport option to the 'testserver' command. Thanks, toddobryan

09/16/07 10:28:50 changed by toddobryan

  • attachment docs.patch added.

09/16/07 10:29:56 changed by toddobryan

  • status changed from closed to reopened.
  • resolution deleted.

There are two typos that are misleading. They're fixed in docs.patch.

09/16/07 11:01:25 changed by adrian

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [6363]) FIxed #5376 -- Fixed typo in testserver docs

Add/Change #5376 (Add --addrport option to testserver command)




Change Properties
Action