Opened 17 years ago
Closed 17 years ago
#5375 closed (fixed)
django-admin.py dumpdata fails because it doesn't inherit options_list from BaseCommand
Reported by: | Owned by: | nobody | |
---|---|---|---|
Component: | Core (Management commands) | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Running {{{django-admin.py dumpdata}} fails with the following traceback:
Traceback (most recent call last): File "./manage.py", line 11, in ? execute_manager(settings) File "/xxx/django/django/core/management/__init__.py", line 163, in execute_manager utility.execute(argv) File "/xxx/django/django/core/management/__init__.py", line 107, in execute self.fetch_command(command_name, argv[0]).run(argv[1:]) File "/xxx/django/django/core/management/base.py", line 59, in run if options.settings: AttributeError: Values instance has no attribute 'settings'
because it doesn't append its own options to the BaseCommand options_list.
Simple patch is
Index: django/core/management/commands/dumpdata.py =================================================================== --- django/core/management/commands/dumpdata.py (revision 6080) +++ django/core/management/commands/dumpdata.py (working copy) @@ -3,7 +3,7 @@ from optparse import make_option class Command(BaseCommand): - option_list = ( + option_list = BaseCommand.option_list + ( make_option('--format', default='json', dest='format', help='Specifies the output serialization format for fixtures'), make_option('--indent', default=None, dest='indent', type='int',
Note:
See TracTickets
for help on using tickets.
(In [6081]) Fixed #5375 -- Added base command options to the options registered against dumpdata. Thanks for the fix, Matthew Flanagan <mattimustang@…>.