SelectDateWidget does not pass through attrs

[Peter Reeves <oneofthemany1@…>]

Using the following code, the output html omits any attributes passed to it.

DataForm.base_fields['dob'].widget = extras.SelectDateWidget(years=range(2007,1899,-1),attrs={'class':'dobclass' })

Below is the output from diff for a patch to django\newforms\extras\widgets.py:

However this does not allow the setting of different attributes per select option.

43c43
<         select_html = Select(choices=month_choices).render(self.month_field % name, month_val)
---
>         select_html = Select(choices=month_choices).render(self.month_field % name, month_val, attrs=self.attrs)
47c47
<         select_html = Select(choices=day_choices).render(self.day_field % name, day_val)
---
>         select_html = Select(choices=day_choices).render(self.day_field % name, day_val, attrs=self.attrs)
51c51
<         select_html = Select(choices=year_choices).render(self.year_field % name, year_val)
---
>         select_html = Select(choices=year_choices).render(self.year_field % name, year_val, attrs=self.attrs)

[Malcolm Tredinnick]

Can you please attach the patch as an attachment, so that we can more easily check and apply it? Thanks.

[Peter Reeves <oneofthemany1@…>]

Patch generated using "diff -Naur"

[Adrian Holovaty]

Looks like a good fix, but it needs unit tests before we can check it in.

[David A Krauth]

The first patch doesn't seem sufficient to meet the requirement that of handling attrs passed to render() should override self.attrs.

For instance, in MultiWidget.render(), each widget component is passed the result of:

final_attrs = self.build_attrs(attrs).

[Matt McClanahan]

The patch for #6230 addresses this ticket as well, although I won't necessarily call this a duplicate.

[Alex Robbins]

A unit test that shows this problem has been fixed

[Alex Robbins]

I can't reproduce this issue. I attached a test that verifies a class attr does show up in the render method. Closing this as worksforme.