Django

Code

Ticket #3698 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

Smarter newforms labling

Reported by: SmileyChris Assigned to: adrian
Milestone: Component: Forms
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I have been using some labels on my newforms fields. Some end with punctuation, which makes the added ":" look a bit silly after it (when using the lazy form rendering methods like as_p())

The patch makes it so the label is not appended with a colon if the field label ends in punctuation.

Attachments

newforms_labling.patch (0.9 kB) - added by SmileyChris on 03/10/07 05:24:19.
newforms_labling.2.patch (2.7 kB) - added by SmileyChris on 03/25/07 18:50:56.
with tests

Change History

03/10/07 05:24:19 changed by SmileyChris

  • attachment newforms_labling.patch added.

03/12/07 19:33:10 changed by SmileyChris

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

03/25/07 16:32:45 changed by adrian

  • stage changed from Design decision needed to Accepted.

Good idea. Write up some unit tests, and we'll put it in.

03/25/07 18:50:56 changed by SmileyChris

  • attachment newforms_labling.2.patch added.

with tests

03/25/07 18:51:22 changed by SmileyChris

  • stage changed from Accepted to Ready for checkin.

04/27/07 09:27:08 changed by russellm

  • status changed from new to closed.
  • resolution set to fixed.

(In [5112]) Fixed #3698 -- Modified newforms labels to only add a colon if the label text doesn't end with punctuation. Thanks, SmileyChris?.

Add/Change #3698 (Smarter newforms labling)




Change Properties
Action