Django

Code

Ticket #3240 (new)

Opened 2 years ago

Last modified 1 year ago

[patch]Django dispatcher misses some errors

Reported by: robin@reportlab.com Assigned to: nobody
Milestone: Component: Core framework
Version: Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 1 Patch needs improvement: 0

Description

The django BaseHandler? misses some errors and also the dispatch mechanism in modpython.py and wsgi.py also allows some errors to pass without being caught. I have a patch which attempts to fix this by

1) factorising out the code for 500 errors 2) moving the code that handles request middleware inside the try block in BaseHandler?.get_resonse 3) factorising out the common dispatch code in modpython/wsgi.py into a BaseHandler?.dispatch_request method and at the same time moving the response middleware into a try block in that method. 4) Use the BaseHandler?.dispatch_request method in the ModPythonHandler?/WSGIHandler call to replace common code.

Attachments

base.py-4290.patch (8.2 kB) - added by robin@reportlab.com on 01/06/07 11:16:57.
patch against svn rev 4290

Change History

01/06/07 11:16:57 changed by robin@reportlab.com

  • attachment base.py-4290.patch added.

patch against svn rev 4290

01/06/07 11:19:08 changed by robin@reportlab.com

  • summary changed from Django dispatcher misses some errors to [patch]Django dispatcher misses some errors.

01/18/07 17:15:03 changed by Simon G. <dev@simon.net.nz>

  • needs_tests set to 1.
  • stage changed from Unreviewed to Accepted.

09/16/07 10:53:03 changed by ubernostrum

#3224 was a duplicate, but has an alternate implementation.


Add/Change #3240 ([patch]Django dispatcher misses some errors)




Change Properties
Action