Django

Code

Ticket #3224 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

[patch] small refactor of the response middleware invocation

Reported by: mihai_preda@yahoo.com Assigned to: nobody
Milestone: Component: Core framework
Version: SVN Keywords: handlers response middleware
Cc: Triage Stage: Design decision needed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Factored the common code which invokes the response middleware out from WSGIHandler and ModPythonHandler? and put it into BaseHandler?.

Attachments

refactor-response-middleware.diff (2.5 kB) - added by mihai_preda@yahoo.com on 01/03/07 10:52:21.
svn diff
resolver.diff (1.4 kB) - added by mihai_preda@yahoo.com on 01/04/07 06:43:53.
[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.
build_url.diff (1.7 kB) - added by mihai_preda@yahoo.com on 01/04/07 07:33:44.
refactor: extracted the build_url() function from middleware/common.py and put it into http.

Change History

01/03/07 10:52:21 changed by mihai_preda@yahoo.com

  • attachment refactor-response-middleware.diff added.

svn diff

01/04/07 06:43:53 changed by mihai_preda@yahoo.com

  • attachment resolver.diff added.

[patch] refactoring: remove code duplication between core.resolvers and core.handlers.base: added method to build a resolver in resolvers.py.

01/04/07 07:33:44 changed by mihai_preda@yahoo.com

  • attachment build_url.diff added.

refactor: extracted the build_url() function from middleware/common.py and put it into http.

01/18/07 15:04:58 changed by SmileyChris

  • stage changed from Unreviewed to Ready for checkin.

Seems

01/18/07 15:22:11 changed by SmileyChris

... ready for checkin to me. Core can decide to push back if need be.

01/22/07 20:25:49 changed by adrian

I'll have a look at this...

02/25/07 23:09:04 changed by jacob

  • stage changed from Ready for checkin to Design decision needed.

I'm setting this back to design decision needed while Adrian looks at it; meanwhile, can someone explain *why* this is needed?

02/26/07 05:28:03 changed by Ramiro Morales <rm0 _at_ gmx.net>

The original submitter created #3228 afterwards and that enhancement depends on the refactoring implemented in this ticket.

09/16/07 10:52:49 changed by ubernostrum

  • status changed from new to closed.
  • resolution set to fixed.

Closing in favor of #3240, which seems to be a more comprehensive refactoring of code common to both handlers.

Add/Change #3224 ([patch] small refactor of the response middleware invocation)




Change Properties
Action