Django

Code

Ticket #2177 (closed: invalid)

Opened 4 years ago

Last modified 2 years ago

[Patch] Free Preview and Posted Templates for Comments App

Reported by: kanashii@kanashii.ca Assigned to: nobody
Milestone: Component: django.contrib.comments
Version: Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Currently in trunk when someone uses the free comments app the included form will redirect to a comment preview however their is no default freepreview.html template to use so I've cleaned up the one DjangoProject? uses and added i18n tags.

Attachments

free_preview.html (1.4 kB) - added by kanashii@kanashii.ca on 06/17/06 01:48:36.
posted.html (361 bytes) - added by kanashii@kanashii.ca on 06/17/06 01:59:03.
free_preview.2.html (1.4 kB) - added by kanashii@kanashii.ca on 06/17/06 02:08:48.
missed a translation
django.po (53.5 kB) - added by coulix on 06/17/06 02:32:50.
adding french translation for "Post comment"
template1.zip (1.5 kB) - added by anonymous on 07/01/06 04:48:29.

Change History

06/17/06 01:48:36 changed by kanashii@kanashii.ca

  • attachment free_preview.html added.

06/17/06 01:59:03 changed by kanashii@kanashii.ca

  • attachment posted.html added.

06/17/06 02:00:05 changed by kanashii@kanashii.ca

  • summary changed from Free Preview Template for Comments App to Free Preview and Posted Templates for Comments App.

Changed to include Posted template as well since it's not included by default either.

06/17/06 02:08:48 changed by kanashii@kanashii.ca

  • attachment free_preview.2.html added.

missed a translation

06/17/06 02:32:50 changed by coulix

  • attachment django.po added.

adding french translation for "Post comment"

06/17/06 21:11:17 changed by Tyson

The template file names are pretty non-uniform, as well. Currently, they are:

freeform.html free_preview.html freecomment_list.html posted.html

Would it be worth it to break backward compatibility slightly and change them to the following?

freecomment_form.html freecomment_preview.html freecomment_list.html freecomment_posted.html

06/18/06 00:46:59 changed by anonymous

  • priority changed from high to normal.
  • summary changed from Free Preview and Posted Templates for Comments App to [Patch] Free Preview and Posted Templates for Comments App.

07/01/06 04:48:29 changed by anonymous

  • attachment template1.zip added.

11/26/06 19:19:46 changed by adrian

  • component changed from Contrib apps to django.contrib.comments.

01/30/07 02:49:27 changed by Simon G. <dev@simon.net.nz>

  • stage changed from Unreviewed to Accepted.

01/30/07 02:49:35 changed by Simon G. <dev@simon.net.nz>

  • has_patch set to 1.

08/09/08 12:16:11 changed by jacob

  • milestone deleted.

08/25/08 17:21:47 changed by jacob

  • status changed from new to closed.
  • resolution set to invalid.

With the new comment system added in [8557], I'm closing all comment-related tickets since they're against an old system. Please open a new ticket for this issue if it still applies in the new system.

Add/Change #2177 ([Patch] Free Preview and Posted Templates for Comments App)




Change Properties
Action