Django

Code

Ticket #1852 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

Print original exception when an unknown error occurs in template

Reported by: nnorwitz@google.com Assigned to: adrian
Milestone: Component: Template system
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

We had a problem when we updated a Model, but not the DB. Loading the template failed and we got a useless error message because of catching the original exception and wrapping it. Only the TemplateSyntaxError? was printed, not the original exception which was very misleading. This was with 0.91, but HEAD has the same issue. Below is a patch that fixes the problem. I didn't see a way to upload a file as a patch.

--- template/init.py.orig 2006-05-12 11:14:27.000000000 -0700 +++ template/init.py 2006-05-12 11:14:00.000000000 -0700 @@ -90,7 +90,20 @@

builtins = []

class TemplateSyntaxError?(Exception):

- pass + def str(self): + try: + import cStringIO as StringIO + except ImportError?: + import StringIO + output = StringIO.StringIO() + output.write(Exception.str(self)) + # Check if we wrapped an exception and print that too. + if hasattr(self, 'exc_info'): + import traceback + output.write('\n\nOriginal ') + e = self.exc_info + traceback.print_exception(e[0], e[1], e[2], 500, output) + return output.getvalue()

class ContextPopException?(Exception):

"pop() has been called more times than push()"

Attachments

template-print.diff (0.8 kB) - added by anonymous on 05/12/06 13:22:50.

Change History

05/12/06 13:22:50 changed by anonymous

  • attachment template-print.diff added.

05/14/06 23:24:49 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [2906]) Fixed #1852 -- Improved TemplateSyntaxError? to display the original exception if str() of the exception raises an exception in itself. Thanks, nnorwitz@google.com


Add/Change #1852 (Print original exception when an unknown error occurs in template)




Change Properties
Action