Django

Code

Ticket #1659 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

[patch] [magic-removal] References to decomissioned "django.models" still exist

Reported by: SmileyChris Assigned to: adrian
Milestone: Component: Core framework
Version: magic-removal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

In the magic removal branch, the following files still have references to django.models which no longer exists: 

django/contrib/auth/models.py
django/contrib/comments/views/karma.py
django/contrib/comments/views/userflags.py

Attachments

karma.diff (1.4 kB) - added by ubernostrum on 04/20/06 16:14:48.
Patch for karma.py to (hopefully) bring it in line with latest m-r
karma.2.diff (1.5 kB) - added by ubernostrum on 04/20/06 16:27:32.
Missed a manager method
userflags.diff (3.6 kB) - added by ubernostrum on 04/20/06 16:27:52.
Updating userflags.py to m-r
userflags.2.diff (3.6 kB) - added by ubernostrum on 04/20/06 16:28:36.
Fix typo
userflags.3.diff (3.6 kB) - added by ubernostrum on 04/20/06 16:29:58.
Pesky manager methods
models.diff (1.2 kB) - added by ubernostrum on 04/21/06 11:34:33.
Fix auth models file for m-r (and remove some Ellington cruft)

Change History

04/19/06 23:22:54 changed by SmileyChris

Oh yea, also: 

docs/authentication.txt
docs/forms.txt
docs/overview.txt
docs/request_response.txt
docs/syndication_feeds.txt

04/19/06 23:29:45 changed by ubernostrum

I'm not seeing anything out of place in the auth models file. It imports django.db.models, not django.models. The other two still need refactoring, though. Since I'm doing some stuff that relies on the comments app, I'll try to get that tomorrow at work.

04/20/06 16:14:48 changed by ubernostrum

  • attachment karma.diff added.

Patch for karma.py to (hopefully) bring it in line with latest m-r

04/20/06 16:27:32 changed by ubernostrum

  • attachment karma.2.diff added.

Missed a manager method

04/20/06 16:27:52 changed by ubernostrum

  • attachment userflags.diff added.

Updating userflags.py to m-r

04/20/06 16:28:36 changed by ubernostrum

  • attachment userflags.2.diff added.

Fix typo

04/20/06 16:29:58 changed by ubernostrum

  • attachment userflags.3.diff added.

Pesky manager methods

04/20/06 16:30:17 changed by ubernostrum

  • summary changed from [magic-removal] References to decomissioned "django.models" still exist to [patch] [magic-removal] References to decomissioned "django.models" still exist.

04/20/06 19:06:24 changed by SmileyChris

Just made sure I had the latest version and yes to django.models still.

Line 215 of auth models file: 

module = __import__('django.models.%s' % settings.AUTH_PROFILE_MODULE, [], [], [''])

04/21/06 11:34:33 changed by ubernostrum

  • attachment models.diff added.

Fix auth models file for m-r (and remove some Ellington cruft)

04/21/06 16:03:03 changed by jkocherhans

The part of this dealing with comments was fixed in #1637.

04/21/06 16:10:31 changed by jkocherhans

django/contrib/auth/models.py fixed in [2723]. Thanks ubernostrum.

04/23/06 16:20:13 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

Is this fixed? Please reopen with specific stuff that still needs to be done, if there is any.

04/23/06 17:44:46 changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.
docs/forms.txt
docs/overview.txt
docs/request_response.txt
docs/syndication_feeds.txt

Still contain references to django.models. There aren't any references in the code anymore however. I'll reopen this for now, but maybe these should be part of another ticket.

04/23/06 17:49:14 changed by adrian

  • status changed from reopened to closed.
  • resolution set to fixed.

We're still working on those docs, so I'm closing the ticket.

06/12/06 05:59:08 changed by Home

  • summary changed from [patch] [magic-removal] References to decomissioned "django.models" still exist to [patch] [magic-removal] References to decomissioned "django.models" still exist.

10/24/06 15:17:23 changed by adrian

  • milestone deleted.

Milestone Version 0.92 deleted

Add/Change #1659 ([patch] [magic-removal] References to decomissioned "django.models" still exist)




Change Properties
Action