Opened 20 years ago

Closed 20 years ago

Last modified 19 years ago

#1637 closed defect (fixed)

[patch] [magic-removal] django.contrib.comments still uses old methods

Reported by: Denis <kuzmichyov@…> Owned by: Adrian Holovaty
Component: Core (Other) Version: magic-removal
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django.contrib.comments.models still uses old methods like get_user() and get_object(),
which are incompatible with M/R

Attachments (5)

models.py.diff​ (2.3 KB ) - added by Denis <kuzmichyov@…> 20 years ago.
models.py.2.diff​ (2.8 KB ) - added by Denis <kuzmichyov@…> 20 years ago.
Missed 1 line in the 1st variant
comments.diff​ (8.4 KB ) - added by Dave St.Germain <dcs@…> 20 years ago.
patch for other comments files
comments.2.diff​ (11.2 KB ) - added by Dave St.Germain <dcs@…> 20 years ago.
included Denis's patch
comments.3.diff​ (17.2 KB ) - added by Dave St.Germain <dcs@…> 20 years ago.
includes other patches to comments

Download all attachments as: .zip

Change History (10)

by Denis <kuzmichyov@…>, 20 years ago

Attachment: models.py.diff​ added

by Denis <kuzmichyov@…>, 20 years ago

Attachment: models.py.2.diff​ added

Missed 1 line in the 1st variant

by Dave St.Germain <dcs@…>, 20 years ago

Attachment: comments.diff​ added

patch for other comments files

by Dave St.Germain <dcs@…>, 20 years ago

Attachment: comments.2.diff​ added

included Denis's patch

comment:1 by Dave St.Germain <dcs@…>, 20 years ago

Summary: django.contrib.comments.models still uses old methods → django.contrib.comments still uses old methods

by Dave St.Germain <dcs@…>, 20 years ago

Attachment: comments.3.diff​ added

includes other patches to comments

comment:2 by Dave St.Germain <dcs@…>, 20 years ago

milestone: → Version 0.92
Summary: django.contrib.comments still uses old methods → [patch] [magic-removal] django.contrib.comments still uses old methods

This ticket (and patch) includes #1659 and #1523. I hope this patch can be applied soon because the broken contrib.comments app is a blocker for me...

comment:3 by James Bennett, 20 years ago

Actually, this patch doesn't quite cover #1659, since it's missing the fixes to the auth models file.

comment:4 by jkocherhans, 20 years ago

Resolution: → fixed
Status: new → closed

(In [2722]) magic-removal: fixed #1637 - django.contrib.comments still uses old methods. Thanks Dave St.Germain and ubernostrum.

comment:5 by Adrian Holovaty, 19 years ago

milestone: Version 0.92

Milestone Version 0.92 deleted

Note: See TracTickets for help on using tickets.
Back to Top