Django

Code

Ticket #1637 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

[patch] [magic-removal] django.contrib.comments still uses old methods

Reported by: Denis <kuzmichyov@gmail.com> Assigned to: adrian
Milestone: Component: Core framework
Version: magic-removal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

django.contrib.comments.models still uses old methods like get_user() and get_object(), which are incompatible with M/R

Attachments

models.py.diff (2.3 kB) - added by Denis <kuzmichyov@gmail.com> on 04/14/06 01:24:36.
models.py.2.diff (2.8 kB) - added by Denis <kuzmichyov@gmail.com> on 04/14/06 01:49:10.
Missed 1 line in the 1st variant
comments.diff (8.4 kB) - added by Dave St.Germain <dcs@adullmoment.com> on 04/14/06 20:50:47.
patch for other comments files
comments.2.diff (11.2 kB) - added by Dave St.Germain <dcs@adullmoment.com> on 04/14/06 20:56:35.
included Denis's patch
comments.3.diff (17.2 kB) - added by Dave St.Germain <dcs@adullmoment.com> on 04/21/06 15:05:29.
includes other patches to comments

Change History

04/14/06 01:24:36 changed by Denis <kuzmichyov@gmail.com>

  • attachment models.py.diff added.

04/14/06 01:49:10 changed by Denis <kuzmichyov@gmail.com>

  • attachment models.py.2.diff added.

Missed 1 line in the 1st variant

04/14/06 20:50:47 changed by Dave St.Germain <dcs@adullmoment.com>

  • attachment comments.diff added.

patch for other comments files

04/14/06 20:56:35 changed by Dave St.Germain <dcs@adullmoment.com>

  • attachment comments.2.diff added.

included Denis's patch

04/14/06 20:57:04 changed by Dave St.Germain <dcs@adullmoment.com>

  • summary changed from django.contrib.comments.models still uses old methods to django.contrib.comments still uses old methods.

04/21/06 15:05:29 changed by Dave St.Germain <dcs@adullmoment.com>

  • attachment comments.3.diff added.

includes other patches to comments

04/21/06 15:09:06 changed by Dave St.Germain <dcs@adullmoment.com>

  • summary changed from django.contrib.comments still uses old methods to [patch] [magic-removal] django.contrib.comments still uses old methods.
  • milestone set to Version 0.92.

This ticket (and patch) includes #1659 and #1523. I hope this patch can be applied soon because the broken contrib.comments app is a blocker for me...

04/21/06 15:44:52 changed by ubernostrum

Actually, this patch doesn't quite cover #1659, since it's missing the fixes to the auth models file.

04/21/06 16:02:02 changed by jkocherhans

  • status changed from new to closed.
  • resolution set to fixed.

(In [2722]) magic-removal: fixed #1637 - django.contrib.comments still uses old methods. Thanks Dave St.Germain and ubernostrum.

10/24/06 15:17:23 changed by adrian

  • milestone deleted.

Milestone Version 0.92 deleted

Add/Change #1637 ([patch] [magic-removal] django.contrib.comments still uses old methods)




Change Properties
Action