makemessages excludes all strings from Javascript after a comment

[Łukasz Rekucki]

A sample code (shortened as much as possible, the original comment was something like "get/set doesn't ...", so it's not synthetic):

/* / ' */ gettext("TEXT");

xgettext doesn't find any translations after the shown comment. Removing either / or ' fixes the problem. This is a bit related to #4695.

[Łukasz Rekucki]

A bit naive patch with tests.

[Łukasz Rekucki]

The patch fixes this particular problem (and some similar to it), but it's not too hard to construct a valid JavaScript that gets omited or improperly mangled by regexps. Just a few examples:

gettext("String"); // This comment won't be caught by pythonize_re and it contains "'" which is a string start in Perl
/* 
 * This one will be removed by the patch
 */
gettext("/* but this one will be too */ 'cause there is no way of telling...");
f(/* ... if it's different from this one */);

The only real fix is having a JavaScript lexer and (probaly simplified) parser instead of a bunch of hacky regexps. No time to do it right now, so maybe someone else wants to do it.

[Julien Phalip]

Patch needs improvement as per Łukasz's comment above.

[Ned Batchelder]

Yes, I'm working on a real patch to include a Javascript lexer.

[Ned Batchelder]

Patch attached to #7704 fixes this problem.

[Jannis Leidel]

In [16333]:

Fixed #7704, #14045 and #15495 -- Introduce a lexer for Javascript to fix multiple problems of the translation of Javascript files with xgettext. Many thanks to Ned Batchelder for his contribution of the JsLex library.