xgettext skips some translation strings in javascript files

[voy@…]

For a simple Javascript source file like this:

// '
gettext("foo");
// '
gettext("bar");

results of make-messages.py run will exclude the "foo" string. Apparently this is related to the presence of apostrophes in the preceding comment. I am using gettext 0.14.4 under win32. I suspect this might be some quirk in relation to xgettext being called with Perl in the language parameter.

[voy@…]

Sorry for the broken new lines.

// '
gettext("foo");
// '
gettext("bar");

[Malcolm Tredinnick]

Fixed description.

[dc]

For this javascript makemessages runs pythonize_re and produces temporary .py file:

// '
gettext("foo");
# '
gettext("bar");

then calls xgettext to process it as perl source.

If we will ignore nonsense conversions, the problem is in pythonize_re which is defined as

r'\n\s*//'

and will not match at the beginning of the file.

But with all that really dirty magic the problem can be in another place.

[Dennis Kaarsemaker]

This one-line fix against current trunk (11227) would solve the problem.

core/management/commands/makemessages.py

@@ -17 +17 @@
 # still sensible for us to use it, since subprocess didn't exist in 2.3.
 warnings.filterwarnings('ignore', category=DeprecationWarning, message=r'os\.popen3')
 
-pythonize_re = re.compile(r'\n\s*//')
+pythonize_re = re.compile(r'(?:^|\n)\s*//')
 
 def handle_extensions(extensions=('html',)):
     """

[Ramiro Morales]

Fix by seveas plus tests

[Ramiro Morales]

I've attached a patch that contains the simple regular expression fix described by seveas plus the beginnings of regression tests for the translatable literal extraction functionality. Hopefully we will be able to expand them with more Javascript extraction corner cases and to add template extraction cases.

[Jannis Leidel]

(In [12441]) Fixed #4695 - Worked around a problem of xgettext ignoring some translation strings in JavaScript files. Thanks, Ramiro Morales.

[Jannis Leidel]

(In [12451]) [1.1.X] Fixed #4695 - Worked around a problem of xgettext ignoring some translation strings in JavaScript files. Thanks, Ramiro Morales.

Backport of r12441.

[Jacob]

Milestone 1.2 deleted