Opened 17 years ago

Closed 17 years ago

Last modified 14 years ago

#9957 closed (fixed)

Feeds discard timezone information from pubdate

Reported by: Rajat Upadhyaya Owned by: Eric Holscher
Component: contrib.syndication Version: dev
Severity: Keywords: atom rss feeds timezone
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Changeset ​8216 which fixed ​7016 calculates the timezone offset with respect to the server timezone. Even if timezone information is already present in the pubdate field (i.e. the datetime.datetime object returned by item_pubdate already contains a tzinfo component), it is discarded. The attached patch checks pubdate for attached timezone information before calculating the offset.

Attachments (1)

feeds_timezone_check.diff​ (521 bytes ) - added by Rajat Upadhyaya 17 years ago.

Download all attachments as: .zip

Change History (8)

by Rajat Upadhyaya, 17 years ago

Attachment: feeds_timezone_check.diff​ added

comment:1 by (none), 17 years ago

milestone: post-1.0

Milestone post-1.0 deleted

comment:2 by Jacob, 17 years ago

milestone: → 1.1
Triage Stage: Unreviewed → Accepted

comment:3 by Eric Holscher, 17 years ago

Needs tests: set

Looks sane to me. Skips the timezone creation magic when it already exists.

Needs tests. I'll do that now.

comment:4 by Eric Holscher, 17 years ago

Owner: changed from nobody to Eric Holscher
Status: new → assigned

Make that, I'll do that later.

comment:5 by Jacob, 17 years ago

Resolution: → fixed
Status: assigned → closed

(In [10435]) Fixed #9957: feeds now respect time zone information provided by the pub date.

comment:6 by Jacob, 17 years ago

(In [10436]) [1.0.X] Fixed #9957: feeds now respect time zone information provided by the pub date. Backport of r10435 from trunk.

comment:7 by Jacob, 14 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top