Django

Code

Ticket #9957 (closed: fixed)

Opened 6 months ago

Last modified 3 months ago

Feeds discard timezone information from pubdate

Reported by: urajat Assigned to: ericholscher
Milestone: 1.1 Component: RSS framework
Version: SVN Keywords: atom rss feeds timezone
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 1 Patch needs improvement: 0

Description

Changeset 8216 which fixed 7016 calculates the timezone offset with respect to the server timezone. Even if timezone information is already present in the pubdate field (i.e. the datetime.datetime object returned by item_pubdate already contains a tzinfo component), it is discarded. The attached patch checks pubdate for attached timezone information before calculating the offset.

Attachments

feeds_timezone_check.diff (0.5 kB) - added by urajat on 01/04/09 20:41:33.

Change History

01/04/09 20:41:33 changed by urajat

  • attachment feeds_timezone_check.diff added.

02/25/09 13:51:44 changed by

  • milestone deleted.

Milestone post-1.0 deleted

02/27/09 09:13:31 changed by jacob

  • needs_better_patch changed.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • milestone set to 1.1.

04/01/09 18:42:21 changed by ericholscher

  • needs_tests set to 1.

Looks sane to me. Skips the timezone creation magic when it already exists.

Needs tests. I'll do that now.

04/01/09 18:54:35 changed by ericholscher

  • owner changed from nobody to ericholscher.
  • status changed from new to assigned.

Make that, I'll do that later.

04/07/09 16:20:21 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [10435]) Fixed #9957: feeds now respect time zone information provided by the pub date.

04/07/09 16:21:19 changed by jacob

(In [10436]) [1.0.X] Fixed #9957: feeds now respect time zone information provided by the pub date. Backport of r10435 from trunk.

Add/Change #9957 (Feeds discard timezone information from pubdate)




Change Properties
Action