Django

Code

Ticket #9953 (closed: duplicate)

Opened 6 months ago

Last modified 6 months ago

postgres backend VERSION_RE fails on beta and RC

Reported by: deserat Assigned to: nobody
Milestone: Component: Core framework
Version: 1.0 Keywords: postgres db backend
Cc: Triage Stage: Unreviewed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

VERSION_RE = re.compile(r'PostgreSQL (\d+)\.(\d+)\.')

Fails to match PostgreSQL 8.3RC3 or any beta etc.... failure is catastrophic and returns a 'NoneType?' has no attribute 'groups' message.

major, minor = VERSION_RE.search(version).groups()

Attachments

Change History

01/04/09 10:30:19 changed by kmtracey

  • status changed from new to closed.
  • needs_better_patch changed.
  • resolution set to duplicate.
  • needs_tests changed.
  • needs_docs changed.

#8737 already notes VERSION_RE has trouble with beta version strings. I've noted this ticket there and I'm closing this as a dupe because we only need one ticket to track fixing VERSION_RE. You may try the regex from the last comment on that ticket, though it looks like it will have to be tweaked to handle RC version strings.

Add/Change #9953 (postgres backend VERSION_RE fails on beta and RC)




Change Properties
Action