Auth login should pass current_site to template, not current_site.name

[walterk]

Currently, django.contrib.auth's login method passes 'current_site.name' to the template:

    return render_to_response(template_name, {
        'form': form,
        redirect_field_name: redirect_to,
        'site_name': current_site.name,
    }, context_instance=RequestContext(request))
login = never_cache(login)

It would be preferable if the dictionary pair were 'site': current_site instead. (This is how django-registration works.) In my current project, 'site_name' overrides a variable defined in a custom context processor, which serves the same function. We prefer to not use contrib.sites to pass the site name and domain to templates, since this requires slightly more set up and maintenance. (E.g., making sure 'example.com' gets replaced whenever the database gets wiped.)

Passing 'site': current_site instead of 'site_name': current_site.name would make contrib.auth behavior more consistent with the django-registration module as well.

[Malcolm Tredinnick]

You can't remove the current values that are passed through, since that would break every single template that is using the existing code. There is an argument for passing in the extra object, however.

[Jacob]

Agreed; there's no reason not to pass the site in there.

[Jacob]

(In [10330]) Fixed #9881: Added the to the login view context, not just the site's name. Thanks, nessita.

[Jacob]

Milestone 1.1 deleted