Opened 17 years ago
Closed 13 years ago
#9800 closed New feature (fixed)
Syndication Framework could implement isPermaLink": "false" to better follow the recommendations of the RSS Advisory Board
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.syndication | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | creecode, mpessas@…, rtnpro, charette.s@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
http://www.rssboard.org/rss-profile-1#element-channel-item-guid
RSS feeds should include a guid:isPermaLink": "false" element when the guid is not a permalink.
Otherwise if guid is not a link and item's link are not unique. RSS isn't valid.
Take a look here: http://www.hoboes.com/Mimsy/?ART=669
Attachments (3)
Change History (16)
comment:1 by , 17 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
by , 17 years ago
| Attachment: | rss-add-isPermaLink-element.diff added |
|---|
comment:2 by , 17 years ago
| Has patch: | set |
|---|
comment:3 by , 17 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Unfortunately, we can't know just from the guid/link whether it is in fact a valid permalink or not. So this patch won't actually work for everyone. If you want validity, use Atom.
comment:4 by , 15 years ago
| milestone: | 1.1 → 1.3 |
|---|---|
| Resolution: | wontfix |
| Status: | closed → reopened |
| Version: | 1.0 → SVN |
Here's another, more backward compatible solution — to let one specify "guid_is_permalink" attribute:
class Rss(Feed):
title = "Chicagocrime.org site news"
link = "http://chicagocrime.org/rss/"
description = "Updates on changes and additions to chicagocrime.org."
guid_is_permalink = False
Once it's specified, <guid> tags in the feed will have isPermalink attribute with appropriate value. If it isn't, isPermalink attribute is omitted.
comment:6 by , 15 years ago
| Severity: | → Normal |
|---|---|
| Type: | → New feature |
comment:7 by , 14 years ago
| Easy pickings: | unset |
|---|---|
| Needs documentation: | set |
| Needs tests: | set |
| Patch needs improvement: | set |
| UI/UX: | unset |
Since the guid is a property of each item, the fact that it's a permalink should be passed somehow in the item description (the item argument of add_item_elements) rather than in the feed's constructor.
comment:8 by , 14 years ago
| Cc: | added |
|---|
comment:9 by , 13 years ago
| Cc: | added |
|---|
comment:10 by , 13 years ago
| Cc: | added |
|---|
Added support for 'isPermalink' attribute in a <guid> element for an item in an RSS feed.
by , 13 years ago
| Attachment: | support_is_permalink_attr_in_rss_guid.patch added |
|---|
Support 'isPermalink' attribute in <guid> element for an item in RSS feed.
comment:11 by , 13 years ago
| Cc: | added |
|---|---|
| Needs documentation: | unset |
| Needs tests: | unset |
| Patch needs improvement: | unset |
| Triage Stage: | Accepted → Ready for checkin |
Patch at github includes doc and tests that passes on Python 2.7.3 and 3.2.3 with SQLite.
Marking as RFC.
comment:13 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Here's the patch.