Django

Code

Ticket #9613 (closed: fixed)

Opened 8 months ago

Last modified 4 months ago

Missing authtestdata.json in Django-1.0.1-final.tar.gz

Reported by: aubonbeurre Assigned to: jbronn
Milestone: Component: Uncategorized
Version: 1.0 Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description (Last modified by jbronn)

Sorry if it is a dup, but contrib/auth/fixtures/authtestdata.json and contrib/auth/tests/templates/registration/login.html seem to be missing in Django-1.0.1-final.tar.gz, compared to svn.

This shows-up when doing regression testing of the auth module: 

FAIL: test_password_change_fails_with_invalid_old_password (django.contrib.auth.tests.views.ChangePasswordTest)

File "j:\sources\facedetector\djangoserver\pythonlib\django\contrib\auth\tests\views.py", line 115, in login
    self.assertEquals(response.status_code, 302)
AssertionError: 200 != 302

I'm on Windows.

Attachments

manifest_contrib_changes.diff (0.7 kB) - added by jbronn on 11/16/08 20:35:23.
Adds missing contrib directories without code in auth and formtools to the MANIFEST.in

Change History

11/16/08 16:50:11 changed by kmtracey

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

Yes, the problem is known. The changes needed to include these files in the distribution tarball were made in r9437/r9474. I don't know what the plans are for rolling a new release, though.

11/16/08 16:50:50 changed by kmtracey

I meant r9473, of course.

11/16/08 19:34:57 changed by kmtracey

Sorry, these have not been fixed in the code yet -- I was clearly distracted when I read this originally since I thought it mentioned gis, not auth. We need to fix these as well.

11/16/08 20:35:23 changed by jbronn

  • attachment manifest_contrib_changes.diff added.

Adds missing contrib directories without code in auth and formtools to the MANIFEST.in

11/16/08 20:36:45 changed by jbronn

  • owner changed from nobody to jbronn.
  • status changed from new to assigned.
  • has_patch set to 1.

Confirmed. Also, the templates for django.contrib.formtools were not included in MANIFEST.in.

11/16/08 20:38:38 changed by jbronn

  • description changed.

11/16/08 20:58:31 changed by mtredinnick

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [9478]) Fixed #9613 -- Added a bunch of files that were missing when the distribution tarball is created. Thanks, Justin Bronn.

11/16/08 21:01:08 changed by mtredinnick

(In [9479]) [1.0.X] Fixed #9613 -- Added a bunch of files that were missing when the distribution tarball is created. Thanks, Justin Bronn.

Backport of r9478 from trunk.

02/25/09 13:51:44 changed by

  • milestone deleted.

Milestone post-1.0 deleted

Add/Change #9613 (Missing authtestdata.json in Django-1.0.1-final.tar.gz)




Change Properties
Action