Opened 16 years ago

Closed 12 years ago

Last modified 12 years ago

#9403 closed Bug (duplicate)

_set_content needs to perform the same _is_string check as the Constructor

Reported by: magneto Owned by: nobody
Component: HTTP handling Version: dev
Severity: Normal Keywords:
Cc: yozh Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the HttpResponse constructor one checks that the input content is a string or an iterator itself.

shouldn't _set_content do the same as well?


Attachments (1)

httpResp_set_content.diff​ (1.3 KB ) - added by magneto 16 years ago.

Download all attachments as: .zip

Change History (14)

by magneto, 16 years ago

Attachment: httpResp_set_content.diff​ added

comment:1 by (none), 15 years ago

milestone: post-1.0

Milestone post-1.0 deleted

comment:2 by Jacob, 15 years ago

Triage Stage: Unreviewed → Design decision needed

Can you explain why this would be needed? Is there an error you've found?

comment:3 by Malcolm Tredinnick, 15 years ago

Triage Stage: Design decision needed → Accepted

I think I understand this one (from memory, it looked pretty obvious the first time I saw it). Is we allow passing an interator to the constructor, then it's consistent to allow also setting the content using the same iterator: it's the same process, just slightly delayed. Right now, that won't work.

Move to "accepted", but if you've got some broader problem, Jacob, feel free to override me. Iterators and HttpResponse are pretty funky right now anyway.

comment:4 by Thejaswi Puthraya, 15 years ago

Component: Uncategorized → HTTP handling

comment:5 by yozh, 14 years ago

Cc: yozh added

comment:6 by yozh, 14 years ago

Could you please resolve the issue? I need to call wsgi handler from django.

comment:7 by Julien Phalip, 13 years ago

Needs tests: set
Severity: → Normal
Type: → Uncategorized

comment:8 by Luke Plant, 13 years ago

Type: Uncategorized → Bug

comment:9 by Aymeric Augustin, 12 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:10 by Aymeric Augustin, 12 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:11 by David Gouldin, 12 years ago

Looks like a duplicate of #16494.

comment:12 by anonymous, 12 years ago

Resolution: → duplicate
Status: new → closed

Agreed, this has been fixed in that other ticket.

comment:13 by Julien Phalip, 12 years ago

Sorry that was me :)

Note: See TracTickets for help on using tickets.
Back to Top