Django

Code

Ticket #9303 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

comment templatetags should be independent of Comment model

Reported by: thejaswi_puthraya Assigned to: nobody
Milestone: 1.1 beta Component: django.contrib.comments
Version: SVN Keywords: comments, templatetags, independent, customize
Cc: carljm, halfdan@halfdans.net Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The comment app templatetags should be independent of the Comment model. This is for the customizability of the comment app.

Attachments

9303_hasattr.diff (0.8 kB) - added by thejaswi_puthraya on 10/04/08 23:36:59.
First method that uses hasattr
9303_model.diff (2.0 kB) - added by thejaswi_puthraya on 10/04/08 23:37:32.
Second method that changes BaseCommentAbstractModel?
9303.diff (0.9 kB) - added by thejaswi_puthraya on 03/19/09 22:00:31.
git-patch against the latest checkout

Change History

10/04/08 23:36:59 changed by thejaswi_puthraya

  • attachment 9303_hasattr.diff added.

First method that uses hasattr

10/04/08 23:37:32 changed by thejaswi_puthraya

  • attachment 9303_model.diff added.

Second method that changes BaseCommentAbstractModel?

10/04/08 23:38:07 changed by thejaswi_puthraya

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

The discussion for this ticket is at http://groups.google.com/group/django-developers/t/562438d7136fbb03

10/06/08 15:46:50 changed by carljm

  • cc set to carl@dirtcircle.com.

10/06/08 15:47:27 changed by carljm

  • stage changed from Unreviewed to Accepted.

01/19/09 12:49:43 changed by carljm

  • cc changed from carl@dirtcircle.com to carljm.

02/23/09 16:46:32 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [9891]) Fixed #9303: comment templatetags no longer assume the built-in comment model.

02/28/09 18:50:46 changed by halfdan

  • cc changed from carljm to carljm, halfdan@halfdans.net.

03/19/09 21:59:33 changed by thejaswi_puthraya

  • status changed from closed to reopened.
  • resolution deleted.
  • milestone set to 1.1 beta.

This bug still exists because the filter on is_public is being tried even before the fieldnames are checked. Looks like this line was overlooked while being checked in...

This bug was identified in http://code.djangoproject.com/ticket/8630#comment:23.

03/19/09 22:00:31 changed by thejaswi_puthraya

  • attachment 9303.diff added.

git-patch against the latest checkout

03/19/09 22:00:58 changed by thejaswi_puthraya

  • has_patch set to 1.

03/21/09 08:46:40 changed by jacob

  • status changed from reopened to closed.
  • resolution set to fixed.

Fixed in [10109].

Add/Change #9303 (comment templatetags should be independent of Comment model)




Change Properties
Action