#9303 closed (fixed)
comment templatetags should be independent of Comment model
| Reported by: | Thejaswi Puthraya | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.comments | Version: | dev |
| Severity: | Keywords: | comments, templatetags, independent, customize | |
| Cc: | Carl Meyer, halfdan@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The comment app templatetags should be independent of the Comment model. This is for the customizability of the comment app.
Attachments (3)
Change History (13)
by , 17 years ago
| Attachment: | 9303_hasattr.diff added |
|---|
by , 17 years ago
| Attachment: | 9303_model.diff added |
|---|
Second method that changes BaseCommentAbstractModel
comment:1 by , 17 years ago
The discussion for this ticket is at http://groups.google.com/group/django-developers/t/562438d7136fbb03
comment:2 by , 17 years ago
| Cc: | added |
|---|
comment:3 by , 17 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:4 by , 17 years ago
| Cc: | added; removed |
|---|
comment:5 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 by , 17 years ago
| Cc: | added |
|---|
comment:7 by , 17 years ago
| milestone: | → 1.1 beta |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
This bug still exists because the filter on is_public is being tried even before the fieldnames are checked. Looks like this line was overlooked while being checked in...
This bug was identified in http://code.djangoproject.com/ticket/8630#comment:23.
comment:8 by , 17 years ago
| Has patch: | set |
|---|
Note:
See TracTickets
for help on using tickets.
First method that uses hasattr