Django

Code

Ticket #9282 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Inclusion of comment-utils moderator facility

Reported by: thejaswi_puthraya Assigned to: jezdez
Milestone: 1.1 beta Component: django.contrib.comments
Version: SVN Keywords: spam filter, comments, comment-utils
Cc: semente@taurinus.org Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

James Bennett's comment-utils spam filtering feature was part of the initial code I wrote for the comments refactor. But due to lack of time to document this feature and the comments-refactor making it in the last minute, this feature was dropped for a later stage.

I have removed all references to akismet. For incorporation with Akismet, they can easily subclass the moderator class and get it done or best, just download it off from the comment-utils site.

Jacob liked this idea and wanted it in after the comments refactor stabilized. I also want to know what the other core-devs and James' think about this.

Attachments

9282.diff (18.7 kB) - added by thejaswi_puthraya on 10/03/08 05:04:54.
svn-patch against latest checkout
9282.2.diff (33.9 kB) - added by thejaswi_puthraya on 01/18/09 22:13:31.
git-patch against the latest checkout. Contains tests and docs. Thanks ubernostrum
comment-utils.r10029.diff (34.7 kB) - added by jezdez on 03/11/09 07:14:58.
Updated patch with sphinxified documentation

Change History

10/03/08 05:04:54 changed by thejaswi_puthraya

  • attachment 9282.diff added.

svn-patch against latest checkout

10/03/08 05:06:15 changed by thejaswi_puthraya

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs set to 1.

For the documentation, James has a lot of docstrings that can be used as documentation. But let's wait and see what the core-devs think.

11/27/08 10:59:05 changed by jezdez

@thejaswi_puthraya Do you plan to work on this? Since if not I'd do it.. :)

01/18/09 22:13:31 changed by thejaswi_puthraya

  • attachment 9282.2.diff added.

git-patch against the latest checkout. Contains tests and docs. Thanks ubernostrum

01/18/09 22:13:56 changed by thejaswi_puthraya

  • needs_docs deleted.

02/01/09 06:14:59 changed by Guilherme Gondim <semente@taurinus.org>

  • cc set to semente@taurinus.org.

03/11/09 05:56:49 changed by jezdez

  • owner changed from nobody to jezdez.
  • status changed from new to assigned.
  • stage changed from Design decision needed to Accepted.

This feature is on the feature list for 1.1 and should therefor be triaged as accepted.

See also http://github.com/jezdez/django/tree/comment-utils for a git patch.

03/11/09 07:14:58 changed by jezdez

  • attachment comment-utils.r10029.diff added.

Updated patch with sphinxified documentation

03/12/09 13:40:34 changed by jezdez

  • milestone set to 1.1.

03/18/09 03:12:30 changed by jezdez

  • milestone changed from 1.1 to 1.1 beta.

03/23/09 16:07:03 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [10122]) Fixed #9282: added a generic comment moderation toolkit. See the documentation for details.

This began life as (part of) James Bennett's comment-utils app, and was adapted to be part of Django by Thejaswi Puthraya and Jannis Leidel. Thanks, all!

Add/Change #9282 (Inclusion of comment-utils moderator facility)




Change Properties
Action