Django

Code

Ticket #9278 (closed: fixed)

Opened 1 year ago

Last modified 1 year ago

Geographic Admin doesn't show vector overlay when LANGUAGE_BIDI is set

Reported by: jbronn Assigned to: jbronn
Milestone: Component: GIS
Version: 1.0 Keywords: gis rtl
Cc: dane.springmeyer@gmail.com Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 1 Patch needs improvement: 0

Description

The vector overlay fails to display for when LANGUAGE_BIDI=True -- right-to-left languages like Arabic and Hebrew.

Attachments

geoadmin_bidi_fail.png (39.7 kB) - added by jbronn on 10/02/08 18:48:09.
No overlay
geoadmin_rtl_fix.patch (0.7 kB) - added by springmeyer on 01/10/09 21:28:02.
Patch to force any OpenLayers? map to maintain ltr text ordering
geoadmin_rtl_fix_v2.diff (4.6 kB) - added by jbronn on 01/12/09 15:00:35.

Change History

10/02/08 18:48:09 changed by jbronn

  • attachment geoadmin_bidi_fail.png added.

No overlay

01/10/09 21:26:14 changed by springmeyer

  • needs_better_patch changed.
  • has_patch set to 1.
  • needs_tests set to 1.
  • needs_docs changed.

It appears that when the LANGUAGE_CODE is set to a right-to-left language (noted in http://code.djangoproject.com/browser/django/trunk/django/conf/global_settings.py#L98 LANGUAGES_BIDI]) OpenLayers? vectors are not plotted in a visible location. This problem is noted here: http://trac.openlayers.org/ticket/1778 and is prompted by the insertion of the dir="rtl" in the <html> element by the Admin App when a rtl language is requested.

It can be avoided by adding dir="ltr" in the OL map div. The patch attached that does this.

01/10/09 21:28:02 changed by springmeyer

  • attachment geoadmin_rtl_fix.patch added.

Patch to force any OpenLayers? map to maintain ltr text ordering

01/10/09 21:29:31 changed by springmeyer

  • cc set to dane.springmeyer@gmail.com.

01/12/09 15:00:35 changed by jbronn

  • attachment geoadmin_rtl_fix_v2.diff added.

01/12/09 20:08:26 changed by jbronn

  • status changed from new to closed.
  • resolution set to fixed.

(In [9733]) Fixed #9278, #9694 -- Geographic overlays now display in admin with right to left langauges; simplified transformation process in OpenLayersWidget to fix Ubuntu 8.10/Apache 2.2.9 crash; updated OpenLayers? version to 2.7.

01/12/09 20:21:07 changed by jbronn

(In [9734]) [1.0.X] Fixed #9278, #9694 -- Geographic overlays now display in admin with right to left langauges; simplified transformation process in OpenLayersWidget to fix Ubuntu 8.10/Apache 2.2.9 crash; updated OpenLayers? version to 2.7.

Backport of r9733 from trunk.

02/25/09 13:51:44 changed by

  • milestone deleted.

Milestone post-1.0 deleted

Add/Change #9278 (Geographic Admin doesn't show vector overlay when LANGUAGE_BIDI is set)




Change Properties
Action