Objects with newlines in representation break popup JavaScript in the admin

[jbronn]

When you have these models:

class Note(models.Model):
    text = models.TextField()

    def __unicode__(self):
        return self.text

class Person(models.Model):
    name = models.CharField(max_length=25)
    note = models.ForeignKey(Note)

    def __unicode__(self):
        return self.name

And the following in admin.py:

from django.contrib import admin
from models import Note, Person

admin.site.register(Note)
admin.site.register(Person)

When entering a Person model in the admin a new may Note created by clicking the plus icon next to the selection list. If the person entering the note presses return and puts newlines in the TextField, the dismissAddAnotherPopup JavaScript chokes on the Notes representation.

Attached is a patch that escapes carriage returns, however, I want some discussion on whether there needs to be any other escaping performed.

[Malcolm Tredinnick]

Should this be done with escapejs() instead? That would handle the cases you've identified and a few dozen others as well. At first glance, it looks like the right tool here, but I might be missing something.

[(none)]

Milestone post-1.0 deleted

[Ramiro Morales]

Duplicate of #2986.