Opened 17 years ago

Closed 17 years ago

Last modified 16 years ago

#9203 closed (fixed)

LatestCommentFeed syndicates old comments

Reported by: hanksims Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords: syndication, rss
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

LatestCommentFeed is actually OldestCommentFeed.

It selects and returns the 40 oldest comments, ordering them by ascending submit_date. It should select and return the 40 newest comments, ordering them by descending submit_date.

Change History (7)

comment:1 by hanksims, 17 years ago

LatestCommentFeed? is actually OldestCommentFeed?.

It selects and returns the 40 oldest comments, ordering them by ascending submit_date. It should select and return the 40 newest comments, ordering them by descending submit_date.

Seems to be a cousin of #8917.

by hanksims, 17 years ago

Attachment: feeds.py.diff​ added

django/contrib/comments/feeds.py

comment:2 by hanksims, 17 years ago

Has patch: set

Sorry -- I can't attach my patch, for whatever reason. Here it is on dpaste:

​http://dpaste.com/hold/80484/

in reply to:  2 comment:3 by Thejaswi Puthraya, 17 years ago

Triage Stage: Unreviewed → Accepted
Version: 1.0 → SVN

Replying to hanksims:

Sorry -- I can't attach my patch, for whatever reason. Here it is on dpaste:

​http://dpaste.com/hold/80484/

Your patch is available don't worry about it. I am enclosing your patch once more.

by Thejaswi Puthraya, 17 years ago

Attachment: 9203.diff​ added

git-patch of the latest checkout

comment:4 by James Bennett, 17 years ago

Resolution: → fixed
Status: new → closed

(In [9088]) Fixed #9203: Restore correct ordering for LatestCommentsFeed

comment:5 by (none), 16 years ago

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top