Django

Code

Ticket #9100 (closed: fixed)

Opened 3 months ago

Last modified 2 months ago

django.contrib.comments missing css class attributes in two preview templates

Reported by: mordyovits Assigned to: nobody
Milestone: Component: django.contrib.comments
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

django/contrib/comments/templates/comments has preview.html and reply_preview.html. Both of them have an input field as follows: 

and <input type="submit" name="submit" value="Post your comment" id="submit"> or make changes:

It's missing a class="submit-post" attribute, making it impossible to keep button styling consistent without modifying the template.

Attachments

comments-button-style.patch (1.2 kB) - added by mordyovits on 09/15/08 23:14:31.
patch adding class attribute to preview templates
9100.diff (0.7 kB) - added by thejaswi_puthraya on 09/27/08 12:09:25.
git-patch against the latest checkout

Change History

09/15/08 23:14:31 changed by mordyovits

  • attachment comments-button-style.patch added.

patch adding class attribute to preview templates

09/16/08 10:48:36 changed by mordyovits

  • needs_better_patch changed.
  • version changed from 1.0 to SVN.
  • needs_tests changed.
  • needs_docs changed.

09/27/08 12:09:25 changed by thejaswi_puthraya

  • attachment 9100.diff added.

git-patch against the latest checkout

09/27/08 12:09:43 changed by thejaswi_puthraya

  • stage changed from Unreviewed to Accepted.

It's a trivial change, yet worth getting it done. Am uploading an updated patch based on mordyovits' but without the one for reply_preview.html. For more details check #9141.

10/05/08 00:10:00 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [9120]) Fixed #9100 -- Added a missing CSS class to a submit button. Thanks, mordyovits and thejaswi_puthraya.

10/05/08 00:20:41 changed by mtredinnick

(In [9127]) [1.0.X] Fixed #9100 -- Added a missing CSS class to a submit button. Thanks, mordyovits and thejaswi_puthraya.

Backport of r9120 from trunk.

Add/Change #9100 (django.contrib.comments missing css class attributes in two preview templates)




Change Properties
Action