urlencode should support MutliValueDict

[Thomas Güttler]

This small patch of django.utils.http lets urlencode() handle list values in MultiValueDict instances
correctly.

Before:

>>> from django.utils.http import urlencode
>>> from django.utils.datastructures import MultiValueDict
>>> urlencode(MultiValueDict({'test': [1, 2, 3]}), doseq=True)
'test=3'

With patch:

>>> urlencode(MultiValueDict({'test': [1, 2, 3]}), doseq=True)
'test=1&test=2&test=3'

[Malcolm Tredinnick]

Repeat after me: "whenever I submit a patch to add a new feature, it must include tests." Thankyou. :-)

[Thomas Güttler]

The new patch includes the unittest written by kratorius.

[Thomas Güttler]

Related: ​http://www.djangosnippets.org/snippets/1159/

[Oliver Beattie]

Hate to nag, but is there a reason this hasn't been committed? Seems like such an obvious change that is actually useful. I'm using a custom urlencode function for now, but I really don't see any reason this shouldn't be checked-in.

[gptvnt]

I verified, the patch is good. Although the tests have been restructured recently and the test patch attached is no longer valid. I take the responsibility of rewriting the test patch as per the latest structure.

[Julien Phalip]

Patch needs improvement as per gptvnt's comment.

[Oliver Beattie]

Updated patch with better tests

[Jannis Leidel]

In [16064]:

Fixed #9089 -- Correctly handle list values in MultiValueDict instances when passed to django.utils.http.urlencode. Thanks, kratorius, guettli and obeattie.