Django

Code

Ticket #9036 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

Discrepancy in admin permissions

Reported by: anonymous Assigned to: manuq
Milestone: 1.1 Component: django.contrib.admin
Version: 1.0 Keywords: pycamp2009
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

in django.contrib.admin.sites.AdminSite?.index permissions are calculated like so:

                perms = {
                    'add': model_admin.has_add_permission(request),
                    'change': model_admin.has_change_permission(request),
                    'delete': model_admin.has_delete_permission(request),
                }

but then in django.contrib.admin.sites.AdminSite?.app_index permissions are done like this:

                    perms = {
                        'add': user.has_perm("%s.%s" % (app_label, model._meta.get_add_permission())),
                        'change': user.has_perm("%s.%s" % (app_label, model._meta.get_change_permission())),
                        'delete': user.has_perm("%s.%s" % (app_label, model._meta.get_delete_permission())),
                    }

Personally I perfer the way that index does it, but either way, it just needs to be standardized so we don't have different pages giving different results.

Attachments

sites.diff (1.0 kB) - added by leanmeandonothingmachine on 09/16/08 14:25:36.
9036-index_perms_discrepancy.diff (0.9 kB) - added by manuq on 03/23/09 08:33:25.

Change History

09/11/08 10:04:04 changed by anonymous

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

09/16/08 14:25:36 changed by leanmeandonothingmachine

  • attachment sites.diff added.

09/16/08 14:26:37 changed by leanmeandonothingmachine

  • has_patch set to 1.

02/25/09 22:04:03 changed by jacob

  • stage changed from Unreviewed to Accepted.
  • milestone set to 1.1.

02/25/09 22:04:27 changed by jacob

The way index does it is correct and should be used in both cases.

03/23/09 08:22:01 changed by manuq

  • keywords set to pycamp2009.
  • owner changed from nobody to manuq.

03/23/09 08:33:25 changed by manuq

  • attachment 9036-index_perms_discrepancy.diff added.

03/23/09 08:39:48 changed by manuq

The patch attached should do it.

04/08/09 14:51:30 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r10451


Add/Change #9036 (Discrepancy in admin permissions)




Change Properties
Action