Nested Inline Support in Admin

SOMEONE DO THIS!!!!

anybody can fix this ?

I attached a patch to enable nested inlines with a depth level of 3 on the change_view of ModelAdmin? depth level of 3 means it is limited to something like: A.inlines[ B ] B.inlines [ C ] C.inlines [ D ]

It's just an experiment to see if it was easily doable so the code is not that great

Replying to pixelcort:

Currently, admin.TabularInline? and admin.StackedInline? do not support inlines themselves. This would allow nested inlines to happen.

Has the attached patch been tested? Anything special in the admin.py configuration? It is not working for me, although the code with the patch was translated successfully. Thanks for a reply.

Replying to anonymous:

Replying to pixelcort:

Currently, admin.TabularInline? and admin.StackedInline? do not support inlines themselves. This would allow nested inlines to happen.

Has the attached patch been tested? Anything special in the admin.py configuration? It is not working for me, although the code with the patch was translated successfully. Thanks for a reply.

I wrote it for a project with a very large number of tables (>100) and with 3 or 4 levels of relations depth between tables very often and doing a specific admin page for every table set would be big work (20+ sets, and more could be added). the code gives you the possibility to do multiple inlines like:

class rab_Inline(TabularInline?):

model = rab

class bar_Inline(TabularInline?):

model = bar inlines = [rab_Inline]

class foo_Admin(AdminModel?):

model = foo inlines = [bar_Inline]

with code like this in your admin.py you have the three tables in the foo object admin page is this working for you? I tested it with 1.0 and 1.0.1. I'm going to upgrade to 1.0.3 soon and test with it too, but it should work

the part that's missing from the patch is EDITING support. You are not able to edit. I took a look at it for a bit but since I dont need it i never implemented it. I remember there's code that puts all the generated html form code in a list, but if you have multiple inlines the order is wrong and only the first added forms can work (the foo object form should work). Expanding that code should add editing support. If you are interest I can provide more details

Replying to vosinh:

Replying to anonymous:

Replying to pixelcort:

Currently, admin.TabularInline? and admin.StackedInline? do not support inlines themselves. This would allow nested inlines to happen.

Has the attached patch been tested? Anything special in the admin.py configuration? It is not working for me, although the code with the patch was translated successfully. Thanks for a reply.

I wrote it for a project with a very large number of tables (>100) and with 3 or 4 levels of relations depth between tables very often and doing a specific admin page for every table set would be big work (20+ sets, and more could be added). the code gives you the possibility to do multiple inlines like: class rab_Inline(TabularInline?): model = rab class bar_Inline(TabularInline?): model = bar inlines = [rab_Inline] class foo_Admin(AdminModel?): model = foo inlines = [bar_Inline] with code like this in your admin.py you have the three tables in the foo object admin page is this working for you? I tested it with 1.0 and 1.0.1. I'm going to upgrade to 1.0.3 soon and test with it too, but it should work the part that's missing from the patch is EDITING support. You are not able to edit. I took a look at it for a bit but since I dont need it i never implemented it. I remember there's code that puts all the generated html form code in a list, but if you have multiple inlines the order is wrong and only the first added forms can work (the foo object form should work). Expanding that code should add editing support. If you are interest I can provide more details

tested with 1.0 and 1.0.1 but not 1.0.2 1.0.3 is typo

Did this patch include into testing?

To give more context why this is useful, let me illustrate this with a common use case.

Suppose you model events that can have one or more occurrences.

Each occurrence has a single location and one or more time slots (e.g. a theatre performance that takes place in hall A on Tuesday and Wednesday and in hall B on Saturday.)

You get the following model structure:

class Event(models.Model):
    name = models.CharField(max_length=255)

    def __unicode__(self):
        return self.name

class Location(models.Model):
    name = models.CharField(max_length=255)

    def __unicode__(self):
        return self.name

class Occurrence(models.Model):
    event = models.ForeignKey(Event)
    location = models.ForeignKey(Location)

class TimeSlot(models.Model):
    occurrence = models.ForeignKey(Occurrence)
    start = models.DateTimeField()
    end = models.DateTimeField()

For the admin, you need occurrences to be displayed when you edit the events. The occurrences themselves need to display times lots. Thus, inline nesting is needed:

class TimeSlotInline(admin.TabularInline):
    model = TimeSlot
    extra = 1

class OccurrenceInline(admin.TabularInline):
    model = Occurrence
    inlines = (TimeSlotInline,)
    extra = 2

class EventAdmin(admin.ModelAdmin):
    inlines = (OccurrenceInline,)

admin.site.register(Event, EventAdmin)
admin.site.register(Location)

A design decision is also needed on how deep the nesting should be. It's possible to support arbitrarily deep nesting with recursion, whether that's feasible or necessary remains open. Perhaps an extension mechanism should be provided so that API users can control the inlines and nesting.

The result could look like this:

I've managed to partially made this patch work for version 1.2 pre-alpha (svn release).

When I go to the adding site the inlines of an inline are being displayed but unfortunately whenever I want to add or save an edit something is crashing.

Is there a working (valid) patch for later versions of django (eg. 1.1)?

Thanks and appreciate the work that you guys contribute. If you want to me to show the changes I had to make to get it work please ask. It wont be a problem.

best regards. mp

I've been putting a bit of effort into this today, and I have come to the conclusion that the method for doing this in the patch is flawed.

It attempts to associate the nested inlines with the base admin model. I think that there probably shouldn't be many changes to the ModelAdmin? class, but that they should all be in InlineModelAdmin?.

I have got some code working, and attached a patch if anyone else is interested.

Basically, I have slightly modified the ModelAdmin? class to include the nested inlines in the change page (I haven't worried about the add page at this stage).

Then, the InlineModelAdmin? has changes to create the inline formsets. Finally, there are a couple of template changes, including a new template for the nested formsets.

I have made a couple of design decisions that reflect my use case for the project I am working on, mainly that I don't have add page support, and only include the nested inlines in a TabularInline?. Each class of inline is a seperate column, and each instance of the related object is a sub-row in that column.

I have an example image: http://s3.amazonaws.com/ember/HGETbz2gS1IXvDlOB3idRmcp0ocFL1VK_l.png

(Note that this uses the Inline properties on this class to not show more than 2, and none if the object is not saved).

Alternate patch: against trunk