Django

Code

Ticket #8995 (new)

Opened 2 years ago

Last modified 1 month ago

django.contrib.sitemaps enhancements

Reported by: john Assigned to: nobody
Milestone: Component: Contrib apps
Version: SVN Keywords: sitemaps
Cc: miracle2k, john Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I needed to put HTTPS URLs in my sitemaps, and wanted to ping search engines other than Google. The attached patch adds those enhancements.

Attachments

sitemaps.diff (7.3 kB) - added by john on 06/18/10 12:15:00.
Patch against r13357 for sitemap enhancements.
search-commit-msg (2 bytes) - added by john on 06/18/10 12:17:11.
Ignore this.

Change History

09/09/08 23:03:32 changed by adrian

  • needs_better_patch changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • needs_docs changed.

Sounds like a reasonable enhancement. It'll have to wait until we have a 1.0.x branch. I have not examined this patch.

11/02/09 01:24:58 changed by miracle2k

  • cc set to miracle2k, .

(follow-up: ↓ 4 ) 11/02/09 15:40:44 changed by miracle2k

It seems yahoo is pinged twice by this patch, once with the sitemap url (super call), and then again with the base url. Any particular reason for this?

(in reply to: ↑ 3 ) 06/18/10 10:02:09 changed by john

Replying to miracle2k:

It seems yahoo is pinged twice by this patch, once with the sitemap url (super call), and then again with the base url. Any particular reason for this?

Well, I'd like to think it was because in trying to get Yahoo! to crawl my sites I found it necessary, but it's been so long I don't remember, and now it does seem redundant and spammy. The overridden ping method can probably be removed entirely, so just the sitemap is submitted.

06/18/10 12:03:02 changed by john

  • cc changed from miracle2k, to miracle2k, john.

I updated the patch to work with recent code. For now I just removed Yahoo, as the ping service seems to be broken and is always returning 403 Forbidden. It's not possible that I reached their rate limit, I tried from multiple IPs, and it seems to be reported pretty widely. Some claim you now need to get an app ID and use the update notification service instead. If that's true, Yahoo hasn't updated their docs.

At any rate, I'm afraid that's all the time I have for this at the moment, so Yahoo's out.

06/18/10 12:15:00 changed by john

  • attachment sitemaps.diff added.

Patch against r13357 for sitemap enhancements.

06/18/10 12:17:11 changed by john

  • attachment search-commit-msg added.

Ignore this.

Add/Change #8995 (django.contrib.sitemaps enhancements)




Change Properties
Action