Django

Code

Ticket #8963 (closed: fixed)

Opened 3 months ago

Last modified 2 months ago

Comments framework should use standard decorators where possible

Reported by: zgoda Assigned to: nobody
Milestone: post-1.0 Component: django.contrib.comments
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Comments framework uses custom method for assuring proper HTTP method is used in view breaking DRY principle. Attached patch fixes this issuel

Attachments

contrib-comments-requirepost.diff (1.1 kB) - added by zgoda on 09/08/08 04:09:18.

Change History

09/08/08 04:09:18 changed by zgoda

  • attachment contrib-comments-requirepost.diff added.

09/08/08 12:35:03 changed by thejaswi_puthraya

  • needs_better_patch changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • needs_docs changed.

Fantastic idea, I never even knew there was a decorator for this.

10/05/08 00:10:37 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [9121]) Fixed #8963 -- Use the require_POST decorator instead of doing things manually in one of the comment views. Thanks, zgoda.

10/05/08 00:21:14 changed by mtredinnick

(In [9128]) [1.0.X] Fixed #8963 -- Use the require_POST decorator instead of doing things manually in one of the comment views. Thanks, zgoda.

Bakcport of r9121 from trunk.

Add/Change #8963 (Comments framework should use standard decorators where possible)




Change Properties
Action