Django

Code

Ticket #896 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

[patch] Error serving media files throught django development server on windows

Reported by: Petar Marić <petar.maric@gmail.com> Assigned to: adrian
Milestone: Component: Core framework
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Symptoms: unable to serve media files on windows, getting a large number of 302 redirects

Problem: It seems that something is replacing slashes with backslashes in the url as shown in django-admins runserver log:

[24/Nov/2005 09:15:23] "GET /media/css/print.css HTTP/1.1" 302 0
[24/Nov/2005 09:15:23] "GET /media/css/css%5Cprint.css HTTP/1.1" 302 0
[24/Nov/2005 09:15:23] "GET /media/css/css%5Cprint.css HTTP/1.1" 302 0
[24/Nov/2005 09:15:23] "GET /media/css/css%5Cprint.css HTTP/1.1" 302 0
...

Solution: replace backslashes in newpath with slashes

Patch:

Index: static.py
===================================================================
--- static.py	(revision 1396)
+++ static.py	(working copy)
@@ -34,7 +34,7 @@
         if part in (os.curdir, os.pardir):
             # strip '.' amd '..' in path
             continue
-        newpath = os.path.join(newpath, part)
+        newpath = os.path.join(newpath, part).replace('\\', '/')
     if newpath and path != newpath:
         return HttpResponseRedirect(newpath)
     fullpath = os.path.join(document_root, newpath) 

Credits: nesh for helping me create this patch

Attachments

Change History

11/24/05 04:58:03 changed by sune.kirkeby@gmail.com

That should be:

-        newpath = os.path.join(newpath, part)
+        newpath = '/'.join(newpath, part)

11/24/05 16:41:05 changed by adrian

  • status changed from new to closed.
  • resolution set to fixed.

(In [1402]) Fixed #896 -- Fixed error in filesystem serve view in Windows. Thanks, Petar Mari?\196?\135 and nesh

10/24/06 15:17:18 changed by adrian

  • milestone deleted.

Milestone Version 0.91 deleted


Add/Change #896 ([patch] Error serving media files throught django development server on windows)




Change Properties
Action