Django

Code

Ticket #8879 (closed: fixed)

Opened 3 months ago

Last modified 2 months ago

ngettext is used in comments framework

Reported by: zgoda Assigned to: nobody
Milestone: Component: django.contrib.comments
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

There is one place where ngettext() is used to translate strings in comment framework code. Since Django is all-unicode inside, ungettext() should be used. Attached patch fixes this issue.

Attachments

contrib-comments-ungettext.diff (1.1 kB) - added by zgoda on 09/04/08 14:46:00.
Patch to replace call to ngettext() where ungettext() should be used

Change History

09/04/08 14:46:00 changed by zgoda

  • attachment contrib-comments-ungettext.diff added.

Patch to replace call to ngettext() where ungettext() should be used

09/21/08 06:27:17 changed by jezdez

  • needs_better_patch changed.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • milestone deleted.

10/05/08 00:06:56 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r9116.

10/05/08 00:16:39 changed by mtredinnick

(In [9123]) [1.0.X] Fixed #8879 -- Used ungettext instead of ngettext in the comments framework. Patch from zgoda.

Backport of r9116 from trunk.

Add/Change #8879 (ngettext is used in comments framework)




Change Properties
Action