Django

Code

Ticket #8855 (closed: duplicate)

Opened 3 months ago

Last modified 3 months ago

Default comment form deficiencies

Reported by: zgoda Assigned to:
Milestone: post-1.0 Component: django.contrib.comments
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Default comment form, as found in comments framework, suffers from some basic deficiencies:

  • submit button labels ("Post" and "Preview") are not marked for translation;
  • the input HTML elements (tags) are not closed, effectively prohibiting document validation as XHTML 1.0

Attached patch fixes these two problems and adds minor change in HTTP method declaration for consistency in style.

Attachments

comments-form.html.diff (1.0 kB) - added by zgoda on 09/03/08 14:52:55.
Comment form fixes

Change History

09/03/08 14:52:55 changed by zgoda

  • attachment comments-form.html.diff added.

Comment form fixes

09/03/08 17:30:13 changed by jarrow

  • status changed from new to assigned.
  • needs_better_patch changed.
  • needs_tests changed.
  • milestone set to 1.0.
  • owner changed from nobody to jarrow.
  • needs_docs changed.

I don't know what to do about the translation strings as we are in string freeze but the tags should be fixed.

09/03/08 17:34:16 changed by jarrow

  • owner deleted.
  • status changed from assigned to new.

09/03/08 17:41:13 changed by jacob

  • milestone changed from 1.0 to post-1.0.

We'll fix this after 1.0 - can't add strings now.

09/03/08 17:47:44 changed by mtredinnick

I agree the XML errors should be fixed, since that could prevent the page from rendering. So I've done that in r8958. But only that. None of the style changes or anything. That can all wait.

09/04/08 01:56:44 changed by zgoda

Looking at default templates provided in comments framework I see there's much more places where such things can be found. As this can be effectively worked around using user-provided forms I agree this should wait for post-1.0.

As there are 2 or 3 different kinds of problems here, I'll create separate tickets for each of there problems (translations, XHTML compliance, style consistency) with appropriate patches. After that I'll ask for closing this ticket in favor of detailed tickets.

09/04/08 02:44:19 changed by zgoda

  • status changed from new to closed.
  • resolution set to duplicate.

Closing this ticket as duplicate in favor of #8868, #8869 and #8870. Each of these tickets solves separate problem found in comment framework templates.

Add/Change #8855 (Default comment form deficiencies)




Change Properties
Action