Django

Code

Ticket #8828 (closed: fixed)

Opened 3 months ago

Last modified 3 months ago

Fix whitespace issue

Reported by: jam Assigned to: brosner
Milestone: Component: Uncategorized
Version: SVN Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I ran into a problem using Rietveld on Google App Engine after updating to revision 8816. I'm attaching a patch that fixes the issue.

Attachments

django1.diff (406 bytes) - added by jam on 09/02/08 23:04:58.
Fix (note it says no newline at the end of the file, but I do have one)

Change History

09/02/08 23:04:58 changed by jam

  • attachment django1.diff added.

Fix (note it says no newline at the end of the file, but I do have one)

09/02/08 23:10:31 changed by mtredinnick

Can you please clarify what "a problem" means? The code there, even with the bonus whitespace is perfectly legal Python. Does Google App Engine have some weird (different from normal Python) parsing rules that is causing this to break?

09/03/08 01:22:29 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [8911]) Fixed #8828 -- Trimmed some trailing whitespace that might have been causing a problem for Google AppEngine?.

09/03/08 15:39:03 changed by jam

Sorry, I thought I copied and pasted the error from App Engine but I had only do that in a private email. Here is the error I was getting, the line it mentioned was the one that had whitespace.

Loading main, app version = 2.156 django.file = '/base/data/home/apps/reviewstest/2.156/django.zip/django/init.py', django.VERSION = (1, 0, 'rc_1') <type 'exceptions.SyntaxError?'>: invalid syntax (widgets.py, line 674) Traceback (most recent call last):

File "/base/data/home/apps/reviewstest/2.156/main.py", line 74, in <module>

import django.forms

File "/base/data/home/apps/reviewstest/2.156/py_zipimport.py", line 239, in load_module

exec code in mod.dict

File "/base/data/home/apps/reviewstest/2.156/init.py", line 14, in <module>

File "/base/data/home/apps/reviewstest/2.156/py_zipimport.py", line 230, in load_module

code = compile(source, fullpath, 'exec')

<type 'exceptions.SyntaxError?'>: invalid syntax (widgets.py, line 674)

Running on yqnd41:4002 statusz INFO


Add/Change #8828 (Fix whitespace issue)




Change Properties
Action