Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#8803 closed (fixed)

Possibility to use username if full name is missing in the comments framework

Reported by: Thejaswi Puthraya Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords: fullname, username, comments
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The ticket summary mentions it all. After a discussion with Jacob on IRC, it was decided to have this though having the full name is always recommended.

Attachments (2)

8803.diff (719 bytes ) - added by Thejaswi Puthraya 16 years ago.
git-patch of the latest checkout
comments-view.diff (597 bytes ) - added by Ben Spaulding 16 years ago.
A little shorter version.

Download all attachments as: .zip

Change History (6)

by Thejaswi Puthraya, 16 years ago

Attachment: 8803.diff added

git-patch of the latest checkout

comment:1 by Ben Spaulding, 16 years ago

I ran into the same issue and found this ticket. Just to reiterate, the view should use the get_full_name() or username because that’s what the model itself does. It just makes sense.

I have attached my patch just because I already had it made and it’s a little shorter. (I don’t care what color the bike shed it is, really.)

by Ben Spaulding, 16 years ago

Attachment: comments-view.diff added

A little shorter version.

comment:2 by Malcolm Tredinnick, 16 years ago

*sigh* You both should be smacked for not providing a test for the fix. :-(

Fortunately, I also stumbled across this and have a local patch with tests that I'll commit shortly.

comment:3 by Malcolm Tredinnick, 16 years ago

Resolution: fixed
Status: newclosed

(In [9118]) Fixed #8803 -- Allow authenticated users without first_name/last_name values set to post comments.

comment:4 by Malcolm Tredinnick, 16 years ago

(In [9125]) [1.0.x] Fixed #8803 -- Allow authenticated users without first_name/last_name values set to post comments.

Backport of r9118 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top