#8803 closed (fixed)
Possibility to use username if full name is missing in the comments framework
Reported by: | Thejaswi Puthraya | Owned by: | nobody |
---|---|---|---|
Component: | contrib.comments | Version: | dev |
Severity: | Keywords: | fullname, username, comments | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
The ticket summary mentions it all. After a discussion with Jacob on IRC, it was decided to have this though having the full name is always recommended.
Attachments (2)
Change History (6)
by , 16 years ago
comment:1 by , 16 years ago
I ran into the same issue and found this ticket. Just to reiterate, the view should use the get_full_name()
or username
because that’s what the model itself does. It just makes sense.
I have attached my patch just because I already had it made and it’s a little shorter. (I don’t care what color the bike shed it is, really.)
comment:2 by , 16 years ago
*sigh* You both should be smacked for not providing a test for the fix. :-(
Fortunately, I also stumbled across this and have a local patch with tests that I'll commit shortly.
comment:3 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
git-patch of the latest checkout