Error when loading malformed MIDDLEWARE_CLASSES path

[anonymous]

If the settings file defines the middleware classes like this:

MIDDLEWARE_CLASSES = ('foo',)

The following code found in /core/handlers/base.py when calling load_middleware():

        for middleware_path in settings.MIDDLEWARE_CLASSES:
            try:
                dot = middleware_path.rindex('.')
                mw_module, mw_classname = middleware_path[:dot], middleware_path[dot+1:]
            except ValueError:
                raise exceptions.ImproperlyConfigured, '"%s" does not look like a middleware module' % (middleware_path)

will throw a ValueError when attempting the rindex('.') method call.

[Noah Slater]

Patch

[Noah Slater]

Attached is how I have patched it localy.

[Adrian Holovaty]

(In [1355]) Fixed #879 -- Middleware loader now throws a better error for MIDDLEWARE_CLASSES value without a dot. Thanks, Noah Slater

[anonymous]

No problem! The grammar of the error message in [1355] has been mangled however. :)

[Noah Slater]

Fixed as I reopened. Heh.