Django

Code

Ticket #8788 (closed: fixed)

Opened 3 months ago

Last modified 3 months ago

correction for some typos in #8805

Reported by: Matthew Flanagan <mattimustang@gmail.com> Assigned to: nobody
Milestone: 1.0 Component: Documentation
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Index: django/forms/models.py
===================================================================
--- django/forms/models.py      (revision 8831)
+++ django/forms/models.py      (working copy)
@@ -244,7 +244,7 @@
             if self.instance.pk is not None:
                 qs = qs.exclude(pk=self.instance.pk)

-            # This cute trick with extra/values is the most efficiant way to
+            # This cute trick with extra/values is the most efficient way to
             # tell if a particular query returns any results.
             if qs.extra(select={'a': 1}).values('a').order_by():
                 model_name = capfirst(self.instance._meta.verbose_name)
Index: docs/topics/forms/modelforms.txt
===================================================================
--- docs/topics/forms/modelforms.txt    (revision 8831)
+++ docs/topics/forms/modelforms.txt    (working copy)
@@ -337,10 +337,10 @@
 Overriding the clean() method
 -----------------------------

-You can overide the ``clean()`` method on a model form to provide additional
+You can override the ``clean()`` method on a model form to provide additional
 validation in the same way you can on a normal form.  However, by default the
 ``clean()`` method validates the uniqueness of fields that are marked as unique
-on the model, and those marked as unque_together, if you would like to overide
+on the model, and those marked as unique_together, if you would like to override
 the ``clean()`` method and maintain the default validation you must call the
 parent class's ``clean()`` method.

Attachments

typos.diff (1.6 kB) - added by Matthew Flanagan <mattimustang@gmail.com> on 09/01/08 23:08:16.
"proper" patch
8788-2.diff (2.3 kB) - added by mir on 09/02/08 01:35:27.

Change History

09/01/08 22:58:11 changed by jacob

  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

Can you please attach a real patch instead of pasting it into the description?

09/01/08 23:08:16 changed by Matthew Flanagan <mattimustang@gmail.com>

  • attachment typos.diff added.

"proper" patch

09/02/08 01:31:15 changed by mir

  • stage changed from Unreviewed to Ready for checkin.
  • component changed from Forms to Documentation.
  • milestone set to 1.0.

There are additional typos in the docs and a paragraph that needs to be broken into two. I'm attaching an improved patch.

09/02/08 01:35:27 changed by mir

  • attachment 8788-2.diff added.

09/02/08 01:39:03 changed by mir

Can someone check the commas, please? I've never really figured out the English comma rules.

09/02/08 14:33:57 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [8872]) Fixed #8788: fixed a few typoes in [8805]. Thanks, Matthew Flanagan and mir.

09/02/08 14:36:23 changed by jacob

mir: perfect use of the commas; well done :)


Add/Change #8788 (correction for some typos in #8805)




Change Properties
Action