Django

Code

Ticket #8716 (closed: fixed)

Opened 3 months ago

Last modified 3 months ago

When a authenticated user post a comments, the field's form is not populate with data of user

Reported by: jmad Assigned to: jmad
Milestone: 1.0 Component: django.contrib.comments
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

When a authenticated user post a comments, the field's form is not populate with full name and email of the user. This bug stems from the fact that the code is testing if "name" and "email" are present or not in "Data". If they are not present, then the code uses data from the user. Ors these two fields are always present in "data". It must test if they are empty or not and not if they are present.

This bug is in svn and beta 2 version.

Attachments

patch_comments.diff (0.7 kB) - added by jmad on 08/30/08 12:49:28.

Change History

08/30/08 12:49:28 changed by jmad

  • attachment patch_comments.diff added.

08/30/08 13:09:55 changed by jmad

  • owner changed from nobody to jmad.
  • needs_better_patch changed.
  • status changed from new to assigned.
  • needs_tests changed.
  • needs_docs changed.

08/30/08 16:12:58 changed by anonymous

  • milestone set to 1.0.

08/30/08 16:19:10 changed by mtredinnick

  • stage changed from Unreviewed to Accepted.

The standard way to test if a dictionary key has non-empty content is if data["name"]: .... The patch style looks more like C and makes the reader wonder why it's trying to do something special.

08/30/08 16:30:05 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [8751]) Fixed #8716: correctly handle name and email in comments from authenticated users.

Add/Change #8716 (When a authenticated user post a comments, the field's form is not populate with data of user)




Change Properties
Action