ModelForm.save() should implement force_insert and force_update, like Model.save()

[Richard Davies <richard.davies@…>]

[8267] added the ability to force an SQL insert (or force an update) via a model's save() method.

The same force_insert and force_update flags should be supported in a modelform's save() method.

These flags enable better control over some edge cases - e.g. force_insert will prevent overwriting existing data if the same primary key has accidentally been specified.

[Richard Davies <richard.davies@…>]

Additional to previous patch

[Richard Davies <richard.davies@…>]

The patch one-more.diff is the most recent, and contains all required changes.

I notice that the two helper functions make_model_save and make_instance_save are not used anywhere in Django, so are probably legacy which could be removed. I haven't done this here - just patched them along with the rest.

[dc]

After this patch ModelForm.save() signature will be different from Form.save(). Is this ok?
Desired effect can already be achieved with

model = model_form.save(commit=False)
model.save(force_insert=True)

[Malcolm Tredinnick]

(In [9539]) Added a short note to the modelforms documentation linking between
save(commit=False) and using force_insert or force_update on the Model.save()
call. Refs #8672.

[Malcolm Tredinnick]

The consensus amongst the maintainers is that complicating the API a bit by adding two extra parameters isn't worth it in this case. I've added a note to the documentation to remind people about commit=False in these circumstances.

[Malcolm Tredinnick]

(In [9541]) [1.0.X] Added a short note to the modelforms documentation linking between
save(commit=False) and using force_insert or force_update on the Model.save()
call. Refs #8672.

Backport of r9539 from trunk.

[(none)]

Milestone post-1.0 deleted