Django

Code

Ticket #8592 (closed: fixed)

Opened 3 months ago

Last modified 3 months ago

Savepoints not completely disabled with PostgreSQL prior to 8.0.

Reported by: mlafon@gmail.com Assigned to: nobody
Milestone: 1.0 Component: Database layer (models, ORM)
Version: 1.0-beta-1 Keywords:
Cc: django@hangya.net Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I am using Django 1.0 beta 1 with PostgreSQL 7.4.

With mod_python, I have the following exception : ProgrammingError: syntax error at or near "SAVEPOINT" at character 1

Savepoints should be disabled with PostgreSQL < 8.0 (Changeset [8317]) but this does not work because it is not disabled in all DatabaseWrapper objects, only the first one. Surely because we are using a class member to store the fact that it has been disabled : self.__class__._version = version

The problem is not present when using manage.py runserver , surely because only one DatabaseWrapper will be created.

Attachments

Change History

08/27/08 03:03:30 changed by anonymous

  • needs_better_patch changed.
  • summary changed from Savepoints non completely disabled with PostgreSQL prior to 8.0. to Savepoints not completely disabled with PostgreSQL prior to 8.0..
  • needs_tests changed.
  • needs_docs changed.

08/27/08 03:05:42 changed by mtredinnick

  • milestone set to 1.0.

08/27/08 14:21:10 changed by jacob

  • stage changed from Unreviewed to Accepted.

08/27/08 18:27:13 changed by Hangya

  • cc set to django@hangya.net.

08/28/08 01:50:11 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

I believe this is fixed by [8648]. Please reopen if the problem still occurs (I don't have any way to test this at the moment, but a manual code inspection revealed a problem in the code).

08/28/08 02:38:12 changed by mlafon@gmail.com

I have verified that the problem is fixed with [8648], thanks.

Add/Change #8592 (Savepoints not completely disabled with PostgreSQL prior to 8.0.)




Change Properties
Action