Admin Fieldset changed css from 'error' to 'errors'

[Robert Myers]

It looks like it may have been just a little oversite. But the new admin changed the css that was applied to the form-row div. It use to be error now it is errors. While this may be technically correct it is a silly change to make since it will require everyone who was using error to style up the row differently.

Case point one: ​http://code.djangoproject.com/ticket/5873

I think that change should be reverted.

Also if this is not changed then you will need to alter the global.css file Here is the relevant part:

/* MESSAGES & ERRORS */

# snip #

.error { background:#ffc; }
.error input, .error select { border:1px solid red; }

And it should be listed in Backwards incompatible Changes if it is not reverted.

[Robert Myers]

fix fieldset error css

[Robert Myers]

Forgot the change to revert 7576

[Jacob]

errors is a better name, and it's easy enough for folks to change their own CSS stylesheets. Let's not flip-flop, and leave it as is.

[Robert Myers]

Fair enough, here is a patch to correct the global.css to 'errors' from 'error'

[Malcolm Tredinnick]

Reopening, since there's still a bug here (adding a patch to a closed ticket won't get it committed).

[anonymous]

Sorry, I wasn't sure of the correct procedure. Whether I can or should have set it to 'reopen'. And I thought this was so minor it wasn't worth bringing up on django-developers.

[Brian Rosner]

(In [8554]) Fixed #8499 -- Corrected a couple of instances of where the CSS class name error should be errors. Thanks rmyers for catching this.

[Jacob]

Milestone 1.0 deleted