Opened 17 years ago
Closed 17 years ago
#8461 closed (wontfix)
manage.py reset crashes running initial SQL if there's a #comment on the same line as valid SQL
| Reported by: | niccl | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Someday/Maybe | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
manage.py reset can run initial SQL. If this SQL has valid SQL at the start, followed by a # comment, then it will fail with
_mysql_exceptions.ProgrammingError: (2014, "Commands out of sync; you can't run this command now")
It fails because the regex in sql.py doesn't check for '# comment' when parsing the SQL file. '# comment' is valid in (at least) MySQL.
Attachments (1)
Change History (3)
by , 17 years ago
| Attachment: | sql_py.diff added |
|---|
comment:1 by , 17 years ago
| Component: | django-admin.py runserver → django-admin.py |
|---|
comment:2 by , 17 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
| Triage Stage: | Unreviewed → Someday/Maybe |
The only types of supported comments for all databases (sqlite,MySQL and PostgreSQL) are:
-- for single line comments
/* … */ for multiline comments
These two are standard compliant
# is a MySQL only extension
Note:
See TracTickets
for help on using tickets.
Doh. finger trouble selecting component