#8434 closed (fixed)
[8443] broke tests
| Reported by: | Owned by: | ||
|---|---|---|---|
| Component: | Internationalization | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Tested on r8445, Debian Etch, Python 2.4.4
======================================================================
FAIL: Doctest: regressiontests.forms.tests.__test__.localflavor_nl_tests
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/django/test/_doctest.py", line 2180, in runTest
raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for regressiontests.forms.tests.__test__.localflavor_nl_tests
File "/srv/lib/django-trunk/tests/regressiontests/forms/tests.py", line unknown line number, in localflavor_nl_tests
----------------------------------------------------------------------
File "/srv/lib/django-trunk/tests/regressiontests/forms/tests.py", line ?, in regressiontests.forms.tests.__test__.localflavor_nl_tests
Failed example:
s.render('provinces', 'OV')
Expected:
u'<select name="provinces">\n<option value="DR">Drente</option>\n<option value="FL">Flevoland</option>\n<option value="FR">Friesland</option>\n<option value="GL">Gelderland</option>\n<option value="GR">Groningen</option>\n<option value="LB">Limburg</option>\n<option value="NB">Noord-Brabant</option>\n<option value="NH">Noord-Holland</option>\n<option value="OV" selected="selected">Overijssel</option>\n<option value="UT">Utrecht</option>\n<option value="ZE">Zeeland</option>\n<option value="ZH">Zuid-Holland</option>\n</select>'
Got:
u'<select name="provinces">\n<option value="DR">Drenthe</option>\n<option value="FL">Flevoland</option>\n<option value="FR">Friesland</option>\n<option value="GL">Gelderland</option>\n<option value="GR">Groningen</option>\n<option value="LB">Limburg</option>\n<option value="NB">Noord-Brabant</option>\n<option value="NH">Noord-Holland</option>\n<option value="OV" selected="selected">Overijssel</option>\n<option value="UT">Utrecht</option>\n<option value="ZE">Zeeland</option>\n<option value="ZH">Zuid-Holland</option>\n</select>'
----------------------------------------------------------------------
Ran 444 tests in 291.684s
FAILED (failures=1)
Attachments (2)
Change History (11)
comment:1 by , 17 years ago
| Component: | Uncategorized → Internationalization |
|---|---|
| Has patch: | set |
| Summary: | Tests fail for r8445 → Tests fail for r8445 (change in NL language file?) |
by , 17 years ago
| Attachment: | drenthe.diff added |
|---|
comment:2 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
Here is the evidence that the change was correct http://nl.wikipedia.org/wiki/Drenthe
comment:3 by , 17 years ago
| Summary: | Tests fail for r8445 (change in NL language file?) → [8443] broke tests |
|---|
Ok, obviously this was [8443] ...
comment:4 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
| Triage Stage: | Unreviewed → Ready for checkin |
Yep, good catch ;)
Just a note about [8443], maybe it would have been good to fix the 35+ occurrences of 'Drente' in the locales. Is that worth a new ticket, or should that be left to the respective translators?
comment:5 by , 17 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Sorry, I must have messed with Trac, I didn't mean to set this as 'fixed'.
comment:6 by , 17 years ago
The above patch fixes all translation files that mentioned Drente.
One occurrence of Drente remains in the PO files: in Spanish Drente is used as the local name for this province and the translator for es-ar actually translated this string. (For the es locale this wasn't done, so there I updated the msgstr as well.)
comment:7 by , 17 years ago
Only the respective translators change PO files. They are never updated by anybody, since the translation also needs to be updated. If the translators are using any kind of translation memory software, the new spelling may bring up a recommended translation.
comment:8 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Looks like we gained an h in Drente ;) If this was intentional, the patch is attached.