Django

Code

Ticket #8434 (closed: fixed)

Opened 3 months ago

Last modified 3 months ago

[8443] broke tests

Reported by: jarrow Assigned to: jarrow
Milestone: 1.0 Component: Internationalization
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Tested on r8445, Debian Etch, Python 2.4.4 

======================================================================
FAIL: Doctest: regressiontests.forms.tests.__test__.localflavor_nl_tests
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/django/test/_doctest.py", line 2180, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for regressiontests.forms.tests.__test__.localflavor_nl_tests
  File "/srv/lib/django-trunk/tests/regressiontests/forms/tests.py", line unknown line number, in localflavor_nl_tests

----------------------------------------------------------------------
File "/srv/lib/django-trunk/tests/regressiontests/forms/tests.py", line ?, in regressiontests.forms.tests.__test__.localflavor_nl_tests
Failed example:
    s.render('provinces', 'OV')
Expected:
    u'<select name="provinces">\n<option value="DR">Drente</option>\n<option value="FL">Flevoland</option>\n<option value="FR">Friesland</option>\n<option value="GL">Gelderland</option>\n<option value="GR">Groningen</option>\n<option value="LB">Limburg</option>\n<option value="NB">Noord-Brabant</option>\n<option value="NH">Noord-Holland</option>\n<option value="OV" selected="selected">Overijssel</option>\n<option value="UT">Utrecht</option>\n<option value="ZE">Zeeland</option>\n<option value="ZH">Zuid-Holland</option>\n</select>'
Got:
    u'<select name="provinces">\n<option value="DR">Drenthe</option>\n<option value="FL">Flevoland</option>\n<option value="FR">Friesland</option>\n<option value="GL">Gelderland</option>\n<option value="GR">Groningen</option>\n<option value="LB">Limburg</option>\n<option value="NB">Noord-Brabant</option>\n<option value="NH">Noord-Holland</option>\n<option value="OV" selected="selected">Overijssel</option>\n<option value="UT">Utrecht</option>\n<option value="ZE">Zeeland</option>\n<option value="ZH">Zuid-Holland</option>\n</select>'


----------------------------------------------------------------------
Ran 444 tests in 291.684s

FAILED (failures=1)

Attachments

drenthe.diff (1.4 kB) - added by jarrow on 08/19/08 19:52:10.
drenthe-translations.diff (13.1 kB) - added by arien on 08/19/08 21:57:39.
patch for test and translation files

Change History

08/19/08 19:52:00 changed by jarrow

  • needs_better_patch changed.
  • component changed from Uncategorized to Internationalization.
  • needs_tests changed.
  • summary changed from Tests fail for r8445 to Tests fail for r8445 (change in NL language file?).
  • needs_docs changed.
  • has_patch set to 1.

Looks like we gained an h in Drente ;) If this was intentional, the patch is attached.

08/19/08 19:52:10 changed by jarrow

  • attachment drenthe.diff added.

08/19/08 20:05:15 changed by jarrow

  • owner changed from nobody to jarrow.
  • status changed from new to assigned.

Here is the evidence that the change was correct http://nl.wikipedia.org/wiki/Drenthe

08/19/08 20:10:37 changed by jarrow

  • summary changed from Tests fail for r8445 (change in NL language file?) to [8443] broke tests.

Ok, obviously this was [8443] ...

08/19/08 20:29:21 changed by julien

  • status changed from assigned to closed.
  • resolution set to fixed.
  • stage changed from Unreviewed to Ready for checkin.

Yep, good catch ;)

Just a note about [8443], maybe it would have been good to fix the 35+ occurrences of 'Drente' in the locales. Is that worth a new ticket, or should that be left to the respective translators?

08/19/08 20:30:42 changed by julien

  • status changed from closed to reopened.
  • resolution deleted.

Sorry, I must have messed with Trac, I didn't mean to set this as 'fixed'.

08/19/08 21:57:39 changed by arien

  • attachment drenthe-translations.diff added.

patch for test and translation files

08/19/08 22:06:48 changed by arien

The above patch fixes all translation files that mentioned Drente.

One occurrence of Drente remains in the PO files: in Spanish Drente is used as the local name for this province and the translator for es-ar actually translated this string. (For the es locale this wasn't done, so there I updated the msgstr as well.)

08/20/08 08:33:34 changed by mtredinnick

Only the respective translators change PO files. They are never updated by anybody, since the translation also needs to be updated. If the translators are using any kind of translation memory software, the new spelling may bring up a recommended translation.

08/20/08 10:56:08 changed by mtredinnick

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [8449]) Fixed #8434 -- I forgot to update the tests when committing [8443]. Thanks, jarrow.

Add/Change #8434 ([8443] broke tests)




Change Properties
Action