Django

Code

Ticket #8283 (closed: fixed)

Opened 4 months ago

Last modified 4 months ago

.filter() is ignored after (query | query) construction

Reported by: dottedmag Assigned to: mtredinnick
Milestone: 1.0 Component: Database layer (models, ORM)
Version: SVN Keywords:
Cc: piranha, benjixx Triage Stage: Accepted
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Model:

from django.db import models
from django.contrib.auth.models import User

class Asset(models.Model):
    public = models.BooleanField(default=True)
    owner = models.ForeignKey(User)

    def __unicode__(self):
        return "%s, %d (%s)" % (self.owner.username, self.id, "public" if self.public else "private")

Let's create several assets:

>>> from testqsbug.models import Asset
>>> from django.contrib.auth.models import User
>>> user1 = User.objects.get(username = "user1")
>>> user2 = User.objects.get(username = "user2")
>>> Asset.objects.create(public=True, owner=user1)
<Asset: user1, 1 (public)>
>>> Asset.objects.create(public=False, owner=user1)
<Asset: user1, 2 (private)>
>>> Asset.objects.create(public=True, owner=user2)
<Asset: user2, 3 (public)>
>>> Asset.objects.create(public=False, owner=user2)
<Asset: user2, 4 (private)>

Let's query all public assets OR assets that belong to some user:

>>> Asset.objects.filter(public=True) | Asset.objects.filter(owner=user1)
[<Asset: user1, 1 (public)>, <Asset: user1, 2 (private)>, <Asset: user2, 3 (public)>]

Let's filter from the result assets owned by user again (silly, I know):

>>> (Asset.objects.filter(public=True) | Asset.objects.filter(owner=user1)).filter(owner=user1)
[<Asset: user1, 1 (public)>, <Asset: user1, 2 (private)>, <Asset: user2, 3 (public)>]

Uhm. Does not work. Both requests resulted in the same query:

>>> q = (Asset.objects.filter(public=True) | Asset.objects.filter(owner=user1))
>>> print q.query
SELECT "testqsbug_asset"."id", "testqsbug_asset"."public", "testqsbug_asset"."owner_id" FROM "testqsbug_asset" WHERE ("testqsbug_asset"."public" = True  OR "testqsbug_asset"."owner_id" = 1 )
>>> q2 = (Asset.objects.filter(public=True) | Asset.objects.filter(owner=user1)).filter(owner=user1)
>>> print q2.query
SELECT "testqsbug_asset"."id", "testqsbug_asset"."public", "testqsbug_asset"."owner_id" FROM "testqsbug_asset" WHERE ("testqsbug_asset"."public" = True  OR "testqsbug_asset"."owner_id" = 1 )

Filtering by another user works fine:

>>> (Asset.objects.filter(public=True) | Asset.objects.filter(owner=user1)).filter(owner=user2)
[<Asset: user2, 3 (public)>]
>>> q3 = (Asset.objects.filter(public=True) | Asset.objects.filter(owner=user1)).filter(owner=user2)
>>> print q3.query
SELECT "testqsbug_asset"."id", "testqsbug_asset"."public", "testqsbug_asset"."owner_id" FROM "testqsbug_asset" WHERE (("testqsbug_asset"."public" = True  OR "testqsbug_asset"."owner_id" = 1 ) AND "testqsbug_asset"."owner_id" = 2 )

Attachments

Change History

08/13/08 13:06:26 changed by mtredinnick

  • needs_better_patch changed.
  • needs_tests changed.
  • milestone set to 1.0.
  • owner changed from nobody to mtredinnick.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.

08/16/08 09:31:44 changed by benjixx

  • cc changed from piranha to piranha, benjixx.

08/16/08 15:40:01 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [8413]) Fixed #8283 -- Fixed an edge case when adding things to the "where" tree and combining different connector types.


Add/Change #8283 (.filter() is ignored after (query | query) construction)




Change Properties
Action