Django

Code

Ticket #8253 (closed: fixed)

Opened 4 months ago

Last modified 4 months ago

Regression: Atom feed lacks xmlns root attribute

Reported by: eibaan Assigned to: jacob
Milestone: 1.0 Component: RSS framework
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Since [8311], the atom feed has no xmlns declaration anymore. The attached patch fixes the problem and adds an regression test.

Attachments

r8319_atom.patch (1.1 kB) - added by eibaan@googlemail.com on 08/12/08 03:48:40.
feed_root_attributes.diff (2.8 kB) - added by jbronn on 08/12/08 13:17:42.
Allows customization of RSS element attributes (w/tests); re-enables XMLNS suport for Atom feeds.

Change History

08/12/08 03:48:40 changed by eibaan@googlemail.com

  • attachment r8319_atom.patch added.

08/12/08 07:59:12 changed by jacob

  • owner changed from nobody to jacob.
  • needs_better_patch changed.
  • status changed from new to assigned.
  • needs_tests changed.
  • needs_docs changed.

08/12/08 13:17:42 changed by jbronn

  • attachment feed_root_attributes.diff added.

Allows customization of RSS element attributes (w/tests); re-enables XMLNS suport for Atom feeds.

(follow-up: ↓ 3 ) 08/12/08 13:34:06 changed by jacob

  • stage changed from Unreviewed to Accepted.
  • milestone set to 1.0.

Restating from IRC: both "root_attributes" *and* "root_element_attributes" is confusing. Maybe "root_attributes" and "feed_attributes"?

(in reply to: ↑ 2 ) 08/12/08 14:24:04 changed by jbronn

Replying to jacob:

Restating from IRC: both "root_attributes" *and* "root_element_attributes" is confusing. Maybe "root_attributes" and "feed_attributes"?

Already updated the patch uses rss_attributes for the RSS-specific options.

08/12/08 17:12:14 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [8331]) Fixed #8253: fixed xmlns regression for Atom feeds, and in the process added a hook for adding attributes specifically on the root <rss> element (for RSS feeds only, of course). Patch by Justin Bronn.

Add/Change #8253 (Regression: Atom feed lacks xmlns root attribute)




Change Properties
Action